Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix re-clicking an ad going to the same landing page should refocus on already open landing page tab #2919

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jul 15, 2019

Fixes brave/brave-browser#5195

Submitter Checklist:

Test Plan:

Confirm that Ads with the same URL as an open tab, bring focus to the already opened tab and do not open a new tab

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@tmancey tmancey merged commit 0b862fe into master Jul 15, 2019
@tmancey tmancey deleted the issues/5195 branch July 15, 2019 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ads: Re-clicking an ad should refocus to an already open landing page tab and not create a new tab
2 participants