Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads: Re-clicking an ad should refocus to an already open landing page tab and not create a new tab #5195

Closed
jsecretan opened this issue Jul 9, 2019 · 1 comment · Fixed by brave/brave-core#2919
Assignees

Comments

@jsecretan
Copy link

Description

When a user already has landing page open from previously clicking and ad or visiting the landing page, we should not create a new tab. Instead, we should look for open tabs matching the landing page and refocus on that tab. We should still send the additional click confirmation.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 5, 2019

Verification passed on

Brave 0.69.123 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified Ads with the same URL as an open tab, bring focus to the already opened tab and do not open a new tab
  • Verified the confirmations View and Click recorded in confirmation.json for the duplicate ad (ad with the same URL). Did not see landed confirmation due to Brave Ads target URLs that redirect to a different hostname are not sustained #4026
  • Verified Estimated pending Rewards amount and Ads notification received count reflect in the Ads panel for the duplicate ad
  • Verified tokens redeemed at server-side for the duplicate ads also (Used Ephoch TS)
    image

Verified passed with

Brave 0.69.124 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X

Verification passed on

Brave 0.69.124 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS
  • Verified Ads with the same URL as an open tab, bring focus to the already opened tab and do not open a new tab. However, if there is a redirect, you will encounter Brave Ads target URLs that redirect to a different hostname are not sustained #4026 and a new tab will be opened.
  • Verified the confirmations View and Click recorded in confirmation.json for the duplicate ad (ad with the same URL).
  • Verified Estimated pending Rewards amount and Ads notification received count reflect in the Ads panel for the duplicate ad
  • Verified tokens redeemed at server-side for the duplicate ad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants