Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Ads target URLs that redirect to a different hostname are not sustained #4026

Closed
tmancey opened this issue Apr 5, 2019 · 4 comments
Closed
Labels
bug closed/duplicate Issue has already been reported feature/ads priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include

Comments

@tmancey
Copy link
Contributor

tmancey commented Apr 5, 2019

Description

Ad Target URLs that redirect to a different hostname are not sustained.

Steps to Reproduce

  1. View an Ad which has a target URL which redirects to a different hostname

Actual result:

Ad fails to confirm that it landed

Expected result:

Ad should confirm that it has landed

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave | 0.63.31 Chromium: 73.0.3683.75 (Official Build) beta(64-bit)
Revision | 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS | Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional Information

See Default/rewards_service/confirmations.json in the user profile directory and chrome-debug.log in the user profile directory for logs.

This is a known limitation, which also exists in Muon. A solution is to store the uuid (aka creative instance id) for the shown Ad as metadata for a tab and match the uuid instead of the hostname. This solution would also work for #3570 (Clicking on Ad landing page gets them included in to a-c)

@tmancey tmancey self-assigned this Apr 5, 2019
@tmancey tmancey removed their assignment Apr 9, 2019
@jsecretan jsecretan added the priority/P3 The next thing for us to work on. It'll ride the trains. label Apr 10, 2019
@helionmelion
Copy link

question: is this the same problem when trying to see wishlist from aliexpress? either disabling shields for this site or entering private mode, the navigation does not pass login verification. Shopping card works.

@LaurenWags
Copy link
Member

Reproduced with

Brave 0.63.45 Chromium: 74.0.3729.75 (Official Build) beta(64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Mac OS X

@LaurenWags
Copy link
Member

When this is fixed, we should check #5195 works for redirects.

@tmancey tmancey changed the title Ad Target URLs that redirect to a different hostname are not sustained Brave Ads target URLs that redirect to a different hostname are not sustained Jan 20, 2020
@tmancey tmancey removed the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 20, 2020
@tmancey
Copy link
Contributor Author

tmancey commented Jul 31, 2020

Closing issue as will be resolved by #11012

@tmancey tmancey closed this as completed Jul 31, 2020
@tmancey tmancey added QA/Yes priority/P3 The next thing for us to work on. It'll ride the trains. release-notes/include closed/duplicate Issue has already been reported labels Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug closed/duplicate Issue has already been reported feature/ads priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include
Projects
Archived in project
Development

No branches or pull requests

4 participants