Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Brave Ads landing pages should not be included in auto-contribute #3570

Closed
mandar-brave opened this issue Mar 4, 2019 · 5 comments
Closed

Fix Brave Ads landing pages should not be included in auto-contribute #3570

mandar-brave opened this issue Mar 4, 2019 · 5 comments
Assignees
@tmancey
Labels
bug closed/wontfix feature/ads OS/Desktop

Comments

@mandar-brave
Copy link

Advertising landing pages should not be considered for auto-contribute.
Tips are OK if the users chooses to tip directly.

cc @bradleyrichter @jsecretan @NejcZdovc @tmancey
@mandar-brave mandar-brave added feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. feature/ads labels Mar 4, 2019
@NejcZdovc
Copy link
Contributor

@tmancey @bridiver do we know if page is ads landing page? Do we add some kind of identifier to the page so that rewards page can pick it up?

@NejcZdovc NejcZdovc assigned NejcZdovc and tmancey and unassigned NejcZdovc Mar 7, 2019
@bridiver
Copy link
Contributor

bridiver commented Mar 7, 2019

@NejcZdovc why would advertiser sites ever be included in the first place? I don't want to autocontribute to Ford no matter how many times I visit their site. It just doesn't make sense.

@NejcZdovc
Copy link
Contributor

@bridiver we don't want that, but currently don't have a way (afaik) to tell which page/tab is ads page and which one is normal one

@tmancey tmancey added the bug label Mar 26, 2019
@tmancey tmancey mentioned this issue Apr 5, 2019
Closed
@tmancey tmancey removed their assignment May 8, 2019
@tmancey tmancey self-assigned this Jul 10, 2019
@tmancey tmancey removed their assignment Jul 15, 2019
@tmancey
Copy link
Contributor

tmancey commented Jul 15, 2019

@jsecretan as agreed on hold, so moving to backlog

@NejcZdovc NejcZdovc added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Jul 16, 2019
@tmancey tmancey removed the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 20, 2020
@tmancey tmancey changed the title Clicking on Ad landing page gets them included in to a-c Clicking on Brave Ads landing page gets them included in to a-c Jan 20, 2020
@tmancey tmancey changed the title Clicking on Brave Ads landing page gets them included in to a-c Brave Ads landing page should not be included in auto-contribute May 3, 2020
@tmancey tmancey added OS/Android Fixes related to Android browser functionality OS/Desktop labels Aug 5, 2020
@tmancey tmancey removed the OS/Android Fixes related to Android browser functionality label Aug 20, 2020
@srirambv srirambv changed the title Brave Ads landing page should not be included in auto-contribute [Desktop] Brave Ads landing page should not be included in auto-contribute Sep 9, 2020
@tmancey tmancey changed the title [Desktop] Brave Ads landing page should not be included in auto-contribute Brave Ads landing page should not be included in auto-contribute Dec 5, 2020
@tmancey tmancey changed the title Brave Ads landing page should not be included in auto-contribute Brave Ads landing pages should not be included in auto-contribute Dec 5, 2020
@tmancey tmancey added enhancement and removed bug labels Mar 6, 2021
@tmancey tmancey added the bug label Apr 13, 2023
@tmancey tmancey changed the title Brave Ads landing pages should not be included in auto-contribute Fix Brave Ads landing pages should not be included in auto-contribute Apr 13, 2023
@tmancey
Copy link
Contributor

tmancey commented Jun 14, 2023

Closing as wont fix

@tmancey tmancey closed this as completed Jun 14, 2023
@tmancey tmancey self-assigned this Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
bug closed/wontfix feature/ads OS/Desktop
Projects
Ads
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bridiver @tmancey @NejcZdovc @mandar-brave