-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Brave Ads landing pages should not be included in auto-contribute #3570
Labels
Comments
mandar-brave
added
feature/rewards
priority/P2
A bad problem. We might uplift this to the next planned release.
feature/ads
labels
Mar 4, 2019
@NejcZdovc why would advertiser sites ever be included in the first place? I don't want to autocontribute to Ford no matter how many times I visit their site. It just doesn't make sense. |
@bridiver we don't want that, but currently don't have a way (afaik) to tell which page/tab is ads page and which one is normal one |
@jsecretan as agreed on hold, so moving to backlog |
NejcZdovc
added
priority/P3
The next thing for us to work on. It'll ride the trains.
and removed
priority/P2
A bad problem. We might uplift this to the next planned release.
labels
Jul 16, 2019
tmancey
removed
the
priority/P3
The next thing for us to work on. It'll ride the trains.
label
Jan 20, 2020
tmancey
changed the title
Clicking on Ad landing page gets them included in to a-c
Clicking on Brave Ads landing page gets them included in to a-c
Jan 20, 2020
tmancey
changed the title
Clicking on Brave Ads landing page gets them included in to a-c
Brave Ads landing page should not be included in auto-contribute
May 3, 2020
tmancey
added
OS/Android
Fixes related to Android browser functionality
OS/Desktop
labels
Aug 5, 2020
srirambv
changed the title
Brave Ads landing page should not be included in auto-contribute
[Desktop] Brave Ads landing page should not be included in auto-contribute
Sep 9, 2020
tmancey
changed the title
[Desktop] Brave Ads landing page should not be included in auto-contribute
Brave Ads landing page should not be included in auto-contribute
Dec 5, 2020
tmancey
changed the title
Brave Ads landing page should not be included in auto-contribute
Brave Ads landing pages should not be included in auto-contribute
Dec 5, 2020
tmancey
changed the title
Brave Ads landing pages should not be included in auto-contribute
Fix Brave Ads landing pages should not be included in auto-contribute
Apr 13, 2023
Closing as wont fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Advertising landing pages should not be considered for auto-contribute.
Tips are OK if the users chooses to tip directly.
cc @bradleyrichter @jsecretan @NejcZdovc @tmancey
The text was updated successfully, but these errors were encountered: