-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow theme change during Welcome onboarding #2909
Conversation
On any Web UI page, you can demo the get (was already present) and the set (which was added by my commit) by opening the console and trying the following:
|
521dfd1
to
d09f054
Compare
60c8054
to
4c98bf3
Compare
3dad384
to
f3fba26
Compare
eb24a52
to
cf1a226
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
cf1a226
to
12d3066
Compare
d80b096
to
a89163b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a89163b
to
f8509ef
Compare
…anging the theme Will be used in welcome screen if user would like to change their theme :)
Co-authored-by: Ross Moody <[email protected]>
Merging in as:
|
Does this drop down still show System theme on OS which does not have system theme (Win10 before 2019, Win8/7, macOS before 2018, Linux)? The purpose of the API which retrieved the list of themes is to make the decision about which are supported on the current system. We should probably use that same code path. Plus, if we’re intending to change the language from Same as xyzOS to System Theme, then we should probably be consistent about that in both Welcome and Settings UI. |
@petemill This drop down won't show the cc: @rossmoody @rebron for thought on parity between the dropdowns for on-boarding and settings page |
Was originally added with #2909 Fixes brave/brave-browser#7461
Fixes brave/brave-browser#4992
Closes brave/brave-browser#4657
Closes brave/brave-browser#3911
Brave-ui (Dependency): brave/brave-ui#487
Quick view:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.