Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update welcome experience layout #4657

Closed
rossmoody opened this issue May 31, 2019 · 2 comments · Fixed by brave/brave-core#2909
Closed

Update welcome experience layout #4657

rossmoody opened this issue May 31, 2019 · 2 comments · Fixed by brave/brave-core#2909

Comments

@rossmoody
Copy link
Contributor

rossmoody commented May 31, 2019

Need to open up the Welcome Experience layout and break it out of the modal cards. This will help with dark mode adoption, responsiveness, larger communication and gives us more room to breathe on smaller screens.

Welcome Light
Welcome Dark

@rossmoody rossmoody self-assigned this May 31, 2019
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 7, 2019
@srirambv
Copy link
Contributor

srirambv commented Jun 7, 2019

Personally I feel the dark mode looks really harsh on screen.There are way too many dark elements and the orange button on dark background looks really harsh. Instead of black background we can probably go with softer gray colour which would still give the dark feel but not as bad as it looks in the screenshot.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 24, 2019

Verification passed on

Brave 0.69.128 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verification passed on

Brave 0.69.128 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS Ubuntu 18.04 LTS

Verification PASSED on macOS 10.14.6 x64 using the following build:

Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.14.6 (Build 18G95)

Screen Shot 2019-09-26 at 3 43 13 PM

Screen Shot 2019-09-26 at 3 43 42 PM

Screen Shot 2019-09-26 at 3 43 25 PM

Screen Shot 2019-09-26 at 3 43 51 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants