Removes AddRecurringPayment as it's not used #2864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylehickinson
requested changes
Jul 4, 2019
| @@ -132,9 +132,6 @@ NS_SWIFT_NAME(BraveLedger) | |||
|
|
|||
| - (void)listRecurringTips:(void (^)(NSArray<BATPublisherInfo *> *))completion; | |||
|
|
|||
| - (void)addRecurringTipToPublisherWithId:(NSString *)publisherId | |||
There was a problem hiding this comment.
On second thought, please leave this here, we are going to use it anyways from UI to add recurring tip
| @@ -488,11 +488,6 @@ - (void)listRecurringTips:(void (^)(NSArray<BATPublisherInfo *> *))completion | |||
| }); | |||
| } | |||
|
|
|||
| - (void)addRecurringTipToPublisherWithId:(NSString *)publisherId amount:(double)amount | |||
| { | |||
| ledger->AddRecurringPayment(std::string(publisherId.UTF8String), amount); | |||
There was a problem hiding this comment.
And instead of removing this entire method, we'll replace this call with:
[BATLedgerDatabase insertOrUpdateRecurringTipWithPublisherID:publisherId
amount:amount
dateAdded:[[NSDate date] timeIntervalSince1970]
completion:nil];Same way that rewards_service_impl handles this in SaveRecurringTip()
[Edit: timeIntervalSinceNow → timeIntervalSince1970]
NejcZdovc
force-pushed
the
recurring-remove
branch
from
7bae28e to
d375390
Compare
NejcZdovc
force-pushed
the
recurring-remove
branch
from
d375390 to
f0cb393
Compare
jasonrsadler
reviewed
Jul 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#5136
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
make sure that CI passes
Reviewer Checklist:
After-merge Checklist:
changes has landed on.