Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AddRecurringPayment from ledger.h #5136

Closed
NejcZdovc opened this issue Jul 4, 2019 · 0 comments · Fixed by brave/brave-core#2864
Closed

Remove AddRecurringPayment from ledger.h #5136

NejcZdovc opened this issue Jul 4, 2019 · 0 comments · Fixed by brave/brave-core#2864
Assignees
@NejcZdovc
Labels
dev-concern feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/No release-notes/exclude
Milestone
0.69.x - Release

Comments

@NejcZdovc
Copy link
Contributor

AddRecurringPayment is not used anymore. Please remove all references to it. We can also remove recurring_donation_ from braveledger_bat_helper::PUBLISHER_STATE_ST
@NejcZdovc NejcZdovc added feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. dev-concern labels Jul 4, 2019
@NejcZdovc NejcZdovc added this to the 0.69.x - Nightly milestone Jul 4, 2019
@NejcZdovc NejcZdovc self-assigned this Jul 4, 2019
@NejcZdovc NejcZdovc mentioned this issue Jul 4, 2019
Merged
32 tasks
NejcZdovc added a commit to brave/brave-core that referenced this issue Jul 4, 2019
@NejcZdovc
Removes AddRecurringPayment as it's not used
f0cb393 
Resolves brave/brave-browser#5136
tmancey pushed a commit that referenced this issue Apr 9, 2020
@kjozwiak
Merge pull request #5136 from brave/pr5129_pub-list_1.7.x
a45aa02 
Change publisher list interval from 1 to 3 days (uplift to 1.7.x)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
dev-concern feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/No release-notes/exclude
Projects
None yet
Milestone
0.69.x - Release
Development

Successfully merging a pull request may close this issue.

Removes AddRecurringPayment as it's not used brave/brave-core
2 participants
@bsclifton @NejcZdovc