Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open Leo from search (uplift to 1.72.x) #26328

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Open Leo from search (uplift to 1.72.x) #26328

merged 2 commits into from
Nov 6, 2024

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Oct 31, 2024 •
edited by kjozwiak
Loading

Uplift of #26082
Resolves brave/brave-browser#41711

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner October 31, 2024 21:19
@brave-builds brave-builds added this to the 1.72.x - Beta milestone Oct 31, 2024
@brave-builds brave-builds self-assigned this Oct 31, 2024
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Oct 31, 2024
@brave-builds
Copy link
Collaborator Author

A Storybook has been deployed to preview UI for the latest push

kjozwiak
kjozwiak approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.72.x approved 👍 QA has verified the PR on Nightly using 1.73.x as per #26082 (comment).

@kjozwiak kjozwiak merged commit 48bb61d into 1.72.x Nov 6, 2024
15 checks passed
@kjozwiak kjozwiak deleted the pr26082_open_leo_from_search_1.72.x branch November 6, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.73.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @yrliou