Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SERP->Leo] Support Save chat in Brave Leo button from Brave Search #41711

Closed
yrliou opened this issue Oct 17, 2024 · 3 comments · Fixed by brave/brave-core#26082
Closed

[SERP->Leo] Support Save chat in Brave Leo button from Brave Search #41711

yrliou opened this issue Oct 17, 2024 · 3 comments · Fixed by brave/brave-core#26082
Assignees
@yrliou
Labels
browser-ai feature-request OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.73.x - Release

Comments

@yrliou
Copy link
Member

yrliou commented Oct 17, 2024 •
edited
Loading

Platforms

Linux, macOS, Windows

Description

When Save chat in Brave Leo button is clicked on Brave Search, we will open Leo side panel with the conversation entries from Brave Search.
A permission prompt will be shown to the user before opening Leo.
@yrliou yrliou self-assigned this Oct 17, 2024
@yrliou yrliou moved this to In Progress in Browser AI Oct 17, 2024
@yrliou yrliou mentioned this issue Oct 17, 2024
Merged
24 tasks
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 21, 2024
@yrliou yrliou mentioned this issue Oct 25, 2024
Open
@github-project-automation github-project-automation bot moved this from In Progress to Done in Browser AI Oct 31, 2024
@brave-builds brave-builds added this to the 1.73.x - Nightly milestone Oct 31, 2024
@brave-builds brave-builds mentioned this issue Oct 31, 2024
Merged
7 tasks
@yrliou yrliou changed the title [SERP->Leo] Support Continue with Leo button from Brave Search [SERP->Leo] Support Save chat in Brave Leo button from Brave Search Oct 31, 2024
@yrliou yrliou mentioned this issue Nov 4, 2024
Merged
24 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Nov 6, 2024

The above requires 1.72.98 or higher for 1.72.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.73.86 Chromium: 131.0.6778.39 (Official Build) (64-bit)
Revision 52163bcf4e40f27ddb76ffa79c90a8833084a9bd
OS Windows 11 Version 23H2 (Build 22631.4317)
  • Verified steps from brave/brave-core#26082
  • Verified enabling search flags and asking a question shows Save chat in Brave Leo
  • Verified clicking on Save chat in Brave Leo opens Leo in side panel
  • Verified if Leo is not enabled/opted-in clicking on Save chat in Brave Leo opens Leo in side panel and shows opt-in disclaimer. Once opted in opening a new chat loads the chat query in Leo
  • Verified the Save chat in Brave Leo option is not shown on private tabs
  • Encountered #42112
41711.mp4

@LaurenWags LaurenWags mentioned this issue Nov 11, 2024
Closed
@LaurenWags
Copy link
Member

changing to release-notes/exclude per discussion with @bbondy @kjozwiak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yrliou yrliou

Labels
browser-ai feature-request OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Browser AI
Status: Done
Milestone
1.73.x - Release
Development

Successfully merging a pull request may close this issue.

Open Leo from search brave/brave-core
6 participants
@kjozwiak @yrliou @rebron @srirambv @LaurenWags @brave-builds