Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening Leo from search should auto populate after user agrees to opt-in #42112

Closed
1 of 6 tasks
srirambv opened this issue Nov 6, 2024 · 3 comments · Fixed by brave/brave-core#26424
Closed
1 of 6 tasks

Comments

@srirambv
Copy link
Contributor

srirambv commented Nov 6, 2024

Description

Opening Leo from search should auto populate after user agrees to opt-in

Steps to reproduce

  1. Clean browser profile
  2. Enable flags for search and enter query
  3. Add follow up questions
  4. Click on save query in brave leo
  5. Side panel opens and shows the opt-in message
  6. Click on I understand/agree to terms
  7. Doesn't auto load the search query into Leo
  8. Click on summarize, does the page summary (this should not be needed IMO)
  9. Click on erase/new chat button, search query loads in Leo

Actual result

Opening Leo from search should auto populate after user agrees to opt-in

Expected result

Should save chat in Leo as soon as the user opts in to Leo

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.73.75 Chromium: 131.0.6778.24 (Official Build) nightly (64-bit)
Revision c3d6b9bdbbdf63fc4831eb0bc8e116e9742e3852
OS Windows 11 Version 23H2 (Build 22631.4317)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

Related to brave/brave-core#26082

cc: @yrliou @kjozwiak

@kjozwiak
Copy link
Member

kjozwiak commented Nov 8, 2024

The above requires 1.74.2 or higher for 1.74.x verification 👍

@kjozwiak
Copy link
Member

The above requires 1.73.88 or higher for 1.73.x verification 👍

@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.73.88 Chromium: 131.0.6778.39 (Official Build) (64-bit)
Revision e0a230f2aab41bbd7935065107eb039f90f0ec70
OS Windows 11 Version 23H2 (Build 22631.4317)
  • Verified steps from issue description
  • Verified Search query chat is shown immediately after user opts into Leo
42112.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment