Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace requests to laptop-updates.brave.com with requests to usage-ping.brave.com and feedback.brave.com #25920

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

DJAndries
Copy link
Collaborator

@DJAndries DJAndries commented Oct 10, 2024

Resolves brave/brave-browser#16374

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Use a MITM proxy to ensure that usage pings are sent to usage-ping.brave.com and Android feedback is sent to feedback.brave.com. On Windows, rename the installer to Brave-Browser-BRV002.exe. Use the proxy to ensure a one-time request is sent to https://usage-ping.brave.com/promo/initialize/nonua with the refcode (BRV002) included in the body.

@DJAndries DJAndries requested review from a team and simonhong as code owners October 10, 2024 05:42
@github-actions github-actions bot added the CI/run-network-audit Run network-audit label Oct 10, 2024
@diracdeltas diracdeltas requested a review from fmarier October 10, 2024 16:35
@DJAndries DJAndries force-pushed the replace-laptop-updates branch from b22e358 to e6e1e78 Compare October 10, 2024 17:59
@DJAndries DJAndries force-pushed the replace-laptop-updates branch 2 times, most recently from 3bd8f97 to 7fcc59d Compare October 10, 2024 18:50
@DJAndries DJAndries force-pushed the replace-laptop-updates branch from 7fcc59d to 356f822 Compare October 10, 2024 21:41
@DJAndries DJAndries requested a review from a team as a code owner October 10, 2024 21:41
@DJAndries DJAndries force-pushed the replace-laptop-updates branch from 356f822 to e63faf8 Compare October 11, 2024 00:16
referral_server = kBraveReferralsServer;
if (env->HasVar("BRAVE_REFERRALS_LOCAL"))
proto = "http";
referral_server = BUILDFLAG(BRAVE_REFERRALS_SERVER);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding another build flag variable for the referrals server, couldn't this use the existing brave_domains::GetServicesDomain(string key) function, which will take a prefix ("usage-ping" or "referrals" in this case) and add the correct domain suffix according to the build environment or cli param overrides.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, i forgot about that function. let me swap that out.

@DJAndries DJAndries force-pushed the replace-laptop-updates branch from e63faf8 to 72d5054 Compare October 15, 2024 23:49
@DJAndries DJAndries changed the base branch from master to add-ping-url-to-list October 15, 2024 23:49
Base automatically changed from add-ping-url-to-list to master October 16, 2024 02:04
@DJAndries DJAndries force-pushed the replace-laptop-updates branch 2 times, most recently from 1e14eff to 50d9b1b Compare October 16, 2024 19:16
@@ -20,8 +20,8 @@ public class DAU {
// TODO: Handle via brave-stats-updater-server switch and get URL from brave_stats_updater_url
let domain =
AppConstants.isOfficialBuild
? "https://laptop-updates.brave.com/"
: "https://laptop-updates.bravesoftware.com/"
? "https://usage-ping.brave.com/"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kylehickinson @Brandon-T we should export BraveServicesDomain to ios

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also hard-coding these url defeats the purpose of not including them in the gn config by default

android/BUILD.gn Outdated Show resolved Hide resolved
…e-ping.brave.com` and `feedback.brave.com`
@DJAndries DJAndries force-pushed the replace-laptop-updates branch from 50d9b1b to 02d588f Compare October 17, 2024 22:38
@DJAndries DJAndries merged commit 9e61c4d into master Oct 18, 2024
17 checks passed
@DJAndries DJAndries deleted the replace-laptop-updates branch October 18, 2024 18:42
@github-actions github-actions bot added this to the 1.73.x - Nightly milestone Oct 18, 2024
@brave-builds
Copy link
Collaborator

Released in v1.73.28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename the laptop-updates.brave.com endpoint
10 participants