-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace requests to laptop-updates.brave.com
with requests to usage-ping.brave.com
and feedback.brave.com
#25920
Conversation
chromium_src/net/tools/transport_security_state_generator/input_file_parsers.cc
Outdated
Show resolved
Hide resolved
b22e358
to
e6e1e78
Compare
3bd8f97
to
7fcc59d
Compare
7fcc59d
to
356f822
Compare
356f822
to
e63faf8
Compare
referral_server = kBraveReferralsServer; | ||
if (env->HasVar("BRAVE_REFERRALS_LOCAL")) | ||
proto = "http"; | ||
referral_server = BUILDFLAG(BRAVE_REFERRALS_SERVER); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of adding another build flag variable for the referrals server, couldn't this use the existing brave_domains::GetServicesDomain(string key)
function, which will take a prefix ("usage-ping"
or "referrals"
in this case) and add the correct domain suffix according to the build environment or cli param overrides.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, i forgot about that function. let me swap that out.
e63faf8
to
72d5054
Compare
1e14eff
to
50d9b1b
Compare
@@ -20,8 +20,8 @@ public class DAU { | |||
// TODO: Handle via brave-stats-updater-server switch and get URL from brave_stats_updater_url | |||
let domain = | |||
AppConstants.isOfficialBuild | |||
? "https://laptop-updates.brave.com/" | |||
: "https://laptop-updates.bravesoftware.com/" | |||
? "https://usage-ping.brave.com/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kylehickinson @Brandon-T we should export BraveServicesDomain
to ios
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also hard-coding these url defeats the purpose of not including them in the gn config by default
…e-ping.brave.com` and `feedback.brave.com`
50d9b1b
to
02d588f
Compare
Released in v1.73.28 |
Resolves brave/brave-browser#16374
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Use a MITM proxy to ensure that usage pings are sent to
usage-ping.brave.com
and Android feedback is sent tofeedback.brave.com
. On Windows, rename the installer toBrave-Browser-BRV002.exe
. Use the proxy to ensure a one-time request is sent tohttps://usage-ping.brave.com/promo/initialize/nonua
with the refcode (BRV002) included in the body.