-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename the laptop-updates.brave.com endpoint #16374
Rename the laptop-updates.brave.com endpoint #16374
Comments
Here's a concrete suggestion:
|
@diracdeltas has a better interim solution for this: remove the |
As part of using the new hostnames, we should add |
|
Related #41659 |
@DJAndries @fmarier due to the way promo codes are done on macOS, we wouldn't be able to verify part of the test plan on macOS until after this is released. Any concerns with just verifying the promo code part of the test plan on the other platforms (Windows, Android, and iOS)? Also, @DJAndries is data for these endpoints starting to come through for Nightly/Beta (even if it's not much yet)? cc @kjozwiak |
Yes, I think that's fine.
yes |
perfect, thanks for the confirmations @DJAndries. @brave/qa-team per the above discussion, when verifying the test plan from brave/brave-core#25920 (comment) on macOS and Linux the referral promo check can be skipped. Full test plan should be verified on Windows, Android, and iOS. |
Verified with
Verified test plan from brave/brave-core#25920 (comment). Note, referral promo was not checked as per #16374 (comment). It will need to be checked on Windows, Android, and iOS. Initial/Install ping:
Daily ping:
Weekly ping:
Monthly ping:
|
Verification
Verified test plan from brave/brave-core#25920 (comment). Note, referral promo was not checked as per #16374 (comment). It will need to be checked on Windows, Android, and iOS. Case 1: Beta build Initial/Install ping
Daily ping
Weekly ping:
Monthly ping:
Case 2: Renamed Beta Build - One-time request Initial ping
Daily ping
Weekly ping
|
Will verify this issue again for promo code on release candidate build when available. |
Verification
Verified test plan from brave/brave-core#25920 (comment). Note, referral promo was not checked as per #16374 (comment). It will need to be checked on Windows, Android, and iOS. Initial/Install ping
Daily ping
Weekly ping:
Monthly ping:
|
Verified on
Verified test plan from brave/brave-core#25920 (comment). NOTE: Will verify this issue again for the referral promo code on the
|
iPhone 14 | iPad Mini (6th gen) |
---|---|
Daily ping
STEPS:
- Continuing from the previous case, close the browser and clear Fiddler/Charles session
- Set system date ahead
24h
- Relaunch browser
- Verify
ACTUAL RESULTS:
- Verified that
https://usage-ping.brave.com
call includesdaily=true
in the ping URL:
https://usage-ping.brave.com/1/usage/ios?channel=beta&version=1.74.0&daily=true&monthly=false&weekly=false&first=false&woi=2024-12-02&wallet2=0&ads_enabled=false&dtoi=2024-12-06&ref=ASA1234567890
iPhone 14 | iPad Mini (6th gen) |
---|---|
Weekly ping
STEPS:
- Continuing from the previous case, close the browser and clear Fiddler/Charles session
- Set system date ahead
7 days
- Relaunch browser
- Verify
ACTUAL RESULTS:
- Verified that
https://usage-ping.brave.com
call includesweekly=true
in the ping URL:
https://usage-ping.brave.com/1/usage/ios?channel=beta&version=1.74.0&weekly=true&daily=true&monthly=false&first=false&woi=2024-12-02&wallet2=0&ads_enabled=false&dtoi=2024-12-06&ref=ASA1234567890
iPhone 14 | iPad Mini (6th gen) |
---|---|
Monthly ping
STEPS:
- Continuing from the previous case, close the browser and clear Fiddler/Charles session
- Set system date ahead
~28-30 days
(so you are in the next month) - Relaunch browser
- Verify
ACTUAL RESULTS:
- Verified that
https://usage-ping.brave.com
call includesmonthly=true
in the ping URL:
https://usage-ping.brave.com/1/usage/ios?channel=beta&version=1.74.0&daily=true&monthly=true&weekly=true&first=false&woi=2024-12-02&wallet2=0&ads_enabled=false&dtoi=null&ref=ASA1234567890
iPhone 14 | iPad Mini (6th gen) |
---|---|
Verified on
Verified test plan from brave/brave-core#25920 (comment). NOTE: Will verify this issue again for the referral promo code on the
|
Galaxy Tab S8 | Pixel 7 |
---|---|
Daily ping
STEPS:
- Continuing from the previous case, close the browser and clear Fiddler/Charles session
- Set system date ahead
24h
- Relaunch browser
- Verify
ACTUAL RESULTS:
- Verified that
https://usage-ping.brave.com
call includesdaily=true
in the ping URL:
https://usage-ping.brave.com/1/usage/brave-core?platform=android-bc&channel=beta&version=1.74.20&daily=true&weekly=false&monthly=false&first=false&woi=2024-12-09&dtoi=2024-12-09&ref=BRV001&adsEnabled=false&arch=&wallet2=0
Galaxy Tab S8 | Pixel 7 |
---|---|
Weekly ping
STEPS:
- Continuing from the previous case, close the browser and clear Fiddler/Charles session
- Set system date ahead
7 days
- Relaunch browser
- Verify
ACTUAL RESULTS:
- Verified that
https://usage-ping.brave.com
call includesweekly=true
in the ping URL:
https://usage-ping.brave.com/1/usage/brave-core?platform=android-bc&channel=beta&version=1.74.20&daily=true&weekly=true&monthly=false&first=false&woi=2024-12-09&dtoi=2024-12-09&ref=BRV001&adsEnabled=false&arch=&wallet2=0
Galaxy Tab S8 | Pixel 7 |
---|---|
Monthly ping
STEPS:
- Continuing from the previous case, close the browser and clear Fiddler/Charles session
- Set system date ahead
~28-30 days
(so you are in the next month) - Relaunch browser
- Verify
ACTUAL RESULTS:
- Verified that
https://usage-ping.brave.com
call includesmonthly=true
in the ping URL:
https://usage-ping.brave.com/1/usage/brave-core?platform=android-bc&channel=beta&version=1.74.20&daily=true&weekly=true&monthly=true&first=false&woi=2024-12-09&dtoi=null&ref=BRV001&adsEnabled=false&arch=&wallet2=0
Galaxy Tab S8 | Pixel 7 |
---|---|
Feedback ping
STEPS:
- Have MITM proxy going (Fiddler, etc)
- Install and launch 1.74.x
- Hamburger menu > Settings
- Support > Rate Brave
- Choose a
negative
face Submit feedback - Verify
ACTUAL RESULTS:
- Verified that the
feedback
is sent tohttps://feedback.brave.com
call:
https://feedback.brave.com/1/feedback
Galaxy Tab S8 | Pixel 7 |
---|---|
Added |
Historically, that endpoint was used for browser updates (in the Muon days). Then the stats / referral ping was added to it as a secondary use.
Now that Muon updates are no longer sent to these old clients, this endpoint is primarily for stats. We should rename it so that the name reflects the nature of the traffic.
Historical uses:
updates.bravesoftware.com
andupdates-cdn.bravesoftware.com
)backtrace.io
)Current uses:
The text was updated successfully, but these errors were encountered: