Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the laptop-updates.brave.com endpoint #16374

Closed
fmarier opened this issue Jun 11, 2021 · 15 comments · Fixed by brave/brave-core#25920 or brave/brave-core#26103
Closed

Rename the laptop-updates.brave.com endpoint #16374

fmarier opened this issue Jun 11, 2021 · 15 comments · Fixed by brave/brave-core#25920 or brave/brave-core#26103

Comments

@fmarier
Copy link
Member

fmarier commented Jun 11, 2021

Historically, that endpoint was used for browser updates (in the Muon days). Then the stats / referral ping was added to it as a secondary use.

Now that Muon updates are no longer sent to these old clients, this endpoint is primarily for stats. We should rename it so that the name reflects the nature of the traffic.

Historical uses:

Current uses:

  • usage pings on all platforms (includes referral code for the first 90 days if any)
  • referral pings when applicable (at first run, and then intermittently until 30 days later when it stops)
  • feedback submissions from Android users who rate the app
@fmarier fmarier added privacy OS/Android Fixes related to Android browser functionality OS/Desktop labels Jun 11, 2021
@fmarier
Copy link
Member Author

fmarier commented Jun 11, 2021

Here's a concrete suggestion:

  • metrics.brave.com for usage pings, referral pings, and installation events
  • feedback.brave.com for webcompat and android feedback

Leave partner headers on laptop-updates for now and work towards removing that mechanism entirely.

@fmarier
Copy link
Member Author

fmarier commented Jun 15, 2021

Leave partner headers on laptop-updates for now and work towards removing that mechanism entirely.

@diracdeltas has a better interim solution for this: remove the /promo/custom-headers endpoint and have this list be hard-coded into brave-core until we can remove it entirely. We're not supposed to be adding to it and so it doesn't need to be updatable outside of the regular release trains. I filed #16455 for this.

@ShivanKaul ShivanKaul added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jul 27, 2021
@fmarier
Copy link
Member Author

fmarier commented Jan 24, 2022

metrics.brave.com and feedback.brave.com were added in https://github.com/brave/devops/pull/6699.

@DJAndries
Copy link
Collaborator

Related #41659

@LaurenWags
Copy link
Member

LaurenWags commented Nov 12, 2024

@DJAndries @fmarier due to the way promo codes are done on macOS, we wouldn't be able to verify part of the test plan on macOS until after this is released. Any concerns with just verifying the promo code part of the test plan on the other platforms (Windows, Android, and iOS)?

Also, @DJAndries is data for these endpoints starting to come through for Nightly/Beta (even if it's not much yet)?

cc @kjozwiak

@DJAndries
Copy link
Collaborator

due to the way promo codes are done on macOS, we wouldn't be able to verify part of the test plan on macOS until after this is released. Any concerns with just verifying the promo code part of the test plan on the other platforms (Windows, Android, and iOS)?

Yes, I think that's fine.

Also, @DJAndries is data for these endpoints starting to come through for Nightly/Beta (even if it's not much yet)?

yes

@LaurenWags
Copy link
Member

perfect, thanks for the confirmations @DJAndries.

@brave/qa-team per the above discussion, when verifying the test plan from brave/brave-core#25920 (comment) on macOS and Linux the referral promo check can be skipped. Full test plan should be verified on Windows, Android, and iOS.

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Nov 18, 2024
@LaurenWags
Copy link
Member

LaurenWags commented Nov 18, 2024

Verified with

Brave	1.74.8 Chromium: 131.0.6778.69 (Official Build) beta (x86_64) 
Revision	0e56a6339728b1f1569eb3bdbe8261f2d5785d3b
OS	macOS Version 14.7.1 (Build 23H222)

Verified test plan from brave/brave-core#25920 (comment). Note, referral promo was not checked as per #16374 (comment). It will need to be checked on Windows, Android, and iOS.

Initial/Install ping:

  1. Have MITM proxy going (Fiddler, etc)
  2. Install and launch 1.74.x
  3. Watch Fiddler for initial/install ping (see first=true in ping URL below):
https://usage-ping.brave.com/1/usage/brave-core?platform=osx-bc&channel=beta&version=1.74.8&daily=true&weekly=true&monthly=true&first=true&woi=2024-11-18&dtoi=2024-11-19&ref=BRV001&adsEnabled=false&arch=&wallet2=0
Example Example
Image Image

Daily ping:

  1. Continuing from previous case, close the browser and clear Fiddler session
  2. Set system date ahead 24h
  3. Relaunch browser
  4. Watch Fiddler for daily ping (see daily=true in ping URL below):
https://usage-ping.brave.com/1/usage/brave-core?platform=osx-bc&channel=beta&version=1.74.8&daily=true&weekly=false&monthly=false&first=false&woi=2024-11-18&dtoi=2024-11-19&ref=BRV001&adsEnabled=false&arch=&wallet2=0
Example Example
Image Image

Weekly ping:

  1. Continuing from previous case, close browser and clear Fiddler session
  2. Set system date ahead 7 days
  3. Relaunch browser
  4. Watch Fiddler for weekly ping (see weekly=true in ping URL below):
https://usage-ping.brave.com/1/usage/brave-core?platform=osx-bc&channel=beta&version=1.74.8&daily=true&weekly=true&monthly=false&first=false&woi=2024-11-18&dtoi=2024-11-19&ref=BRV001&adsEnabled=false&arch=&wallet2=0
Example Example
Image Image

Monthly ping:

  1. Continuing from previous case, close browser and clear Fiddler session
  2. Set system date ahead ~28-30 days (so you are in the next month)
  3. Relaunch browser
  4. Watch Fiddler for monthly ping (see monthly=true in ping URL below):
https://usage-ping.brave.com/1/usage/brave-core?platform=osx-bc&channel=beta&version=1.74.8&daily=true&weekly=true&monthly=true&first=false&woi=2024-11-18&dtoi=null&ref=BRV001&adsEnabled=false&arch=&wallet2=0
Example Example
Image Image

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 19, 2024
@MadhaviSeelam
Copy link

MadhaviSeelam commented Nov 19, 2024

Verification PASSED using

Brave | 1.74.8 Chromium: 131.0.6778.69 (Official Build) beta (64-bit)
-- | --
Revision | 0e56a6339728b1f1569eb3bdbe8261f2d5785d3b
OS | Windows 11 Version 23H2 (Build 22631.4460)

Verified test plan from brave/brave-core#25920 (comment). Note, referral promo was not checked as per #16374 (comment). It will need to be checked on Windows, Android, and iOS.

Case 1: Beta build

Initial/Install ping
  1. Have MITM proxy going (Fiddler, etc)
  2. Install and launch 1.74.x
  3. Watch Fiddler for initial/install ping (see first=true in ping URL below):
https://usage-ping.brave.com/1/usage/brave-core?platform=winx64-bc&channel=beta&version=1.74.8&daily=true&weekly=true&monthly=true&first=true&woi=2024-11-18&dtoi=2024-11-20&ref=BRV001&adsEnabled=false&arch=&wallet2=0
example example
Image Image
Daily ping
  1. Continuing from previous case, close the browser and clear Fiddler session
  2. Set system date ahead 24h
  3. Relaunch browser
  4. Watch Fiddler for daily ping (see daily=true in ping URL below):
https://usage-ping.brave.com/1/usage/brave-core?platform=winx64-bc&channel=beta&version=1.74.8&daily=true&weekly=false&monthly=false&first=false&woi=2024-11-18&dtoi=2024-11-20&ref=BRV001&adsEnabled=false&arch=&wallet2=0
example example
Image Image
Weekly ping:
  1. Continuing from previous case, close browser and clear Fiddler session
  2. Set system date ahead 7 days
  3. Relaunch browser
  4. Watch Fiddler for weekly ping (see weekly=true in ping URL below):
https://usage-ping.brave.com/1/usage/brave-core?platform=winx64-bc&channel=beta&version=1.74.8&daily=true&weekly=true&monthly=false&first=false&woi=2024-11-18&dtoi=2024-11-20&ref=BRV001&adsEnabled=false&arch=&wallet2=0
example example
Image Image
Monthly ping:
  1. Continuing from previous case, close browser and clear Fiddler session
  2. Set system date ahead ~28-30 days (so you are in the next month)
  3. Relaunch browser
  4. Watch Fiddler for monthly ping (see monthly=true in ping URL below):
https://usage-ping.brave.com/1/usage/brave-core?platform=winx64-bc&channel=beta&version=1.74.8&daily=true&weekly=true&monthly=true&first=false&woi=2024-11-18&dtoi=null&ref=BRV001&adsEnabled=false&arch=&wallet2=0
example example
Image Image

Case 2: Renamed Beta Build - One-time request

Initial ping
  1. Download 1.74.8
  2. renamed the build from BraveBrowserStandaloneBetaSetup.exe to Brave-Browser-BRV002.exe
  3. Have MITM proxy going (Fiddler)
  4. disconnect WiFi (so it won't fetch release build)
  5. installed the build from step 2 (Brave-Browser-BRV002.exe)
  6. closed and relaunched Brave
https://usage-ping.brave.com/1/usage/brave-core?platform=winx64-bc&channel=beta&version=1.74.6&daily=true&weekly=true&monthly=true&first=true&woi=2024-11-18&dtoi=2024-11-20&ref=BRV002&adsEnabled=false&arch=&wallet2=0
example example example example
Image Image Image Image
Daily ping
  1. Continuing from previous case, close the browser and clear Fiddler session
  2. Set system date ahead 24h
  3. Relaunch browser
  4. Watch Fiddler for daily ping (see daily=true in ping URL below):
https://usage-ping.brave.com/1/usage/brave-core?platform=winx64-bc&channel=beta&version=1.74.6&daily=true&weekly=false&monthly=false&first=false&woi=2024-11-18&dtoi=2024-11-20&ref=BRV002&adsEnabled=false&arch=&wallet2=0
example example
Image Image
Weekly ping
  1. Continuing from previous case, close browser and clear Fiddler session
  2. Set system date ahead 7 days
  3. Relaunch browser
  4. Watch Fiddler for weekly ping (see weekly=true in ping URL below):
https://usage-ping.brave.com/1/usage/brave-core?platform=winx64-bc&channel=beta&version=1.74.8&daily=true&weekly=true&monthly=false&first=false&woi=2024-11-18&dtoi=2024-11-20&ref=BRV002&adsEnabled=false&arch=&wallet2=0
example example
Image Image

@MadhaviSeelam MadhaviSeelam added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Win64 labels Nov 20, 2024
@MadhaviSeelam
Copy link

Will verify this issue again for promo code on release candidate build when available.

@btlechowski
Copy link

Verification PASSED using

Brave 1.74.20 Chromium: 131.0.6778.108 (Official Build) beta (64-bit)
Revision 6f52e170fb1611fc69347fb24bca600ed052f7b3
OS Linux

Verified test plan from brave/brave-core#25920 (comment). Note, referral promo was not checked as per #16374 (comment). It will need to be checked on Windows, Android, and iOS.

Initial/Install ping
  1. Have MITM proxy going (Fiddler, etc)
  2. Install and launch 1.74.x
  3. Watch proxy for initial/install ping (see first=true in ping URL below):
https://usage-ping.brave.com/1/usage/brave-core?platform=linux-bc&channel=beta&version=1.74.20&daily=true&weekly=true&monthly=true&first=true&woi=2024-12-02&dtoi=2024-12-05&ref=BRV001&adsEnabled=false&arch=&wallet2=0

Image

Daily ping
  1. Continuing from previous case, close the browser and clear Fiddler session
  2. Set system date ahead 24h
  3. Relaunch browser
  4. Watch Fiddler for daily ping (see daily=true in ping URL below):
https://usage-ping.brave.com/1/usage/brave-core?platform=linux-bc&channel=beta&version=1.74.20&daily=true&weekly=false&monthly=false&first=false&woi=2024-12-02&dtoi=2024-12-05&ref=BRV001&adsEnabled=false&arch=&wallet2=0

Image

Weekly ping:
  1. Continuing from previous case, close browser and clear Fiddler session
  2. Set system date ahead 7 days
  3. Relaunch browser
  4. Watch Fiddler for weekly ping (see weekly=true in ping URL below):
https://usage-ping.brave.com/1/usage/brave-core?platform=linux-bc&channel=beta&version=1.74.20&daily=true&weekly=true&monthly=false&first=false&woi=2024-12-02&dtoi=2024-12-05&ref=BRV001&adsEnabled=false&arch=&wallet2=0

Image

Monthly ping:
  1. Continuing from previous case, close browser and clear Fiddler session
  2. Set system date ahead ~28-30 days (so you are in the next month)
  3. Relaunch browser
  4. Watch Fiddler for monthly ping (see monthly=true in ping URL below):
https://usage-ping.brave.com/1/usage/brave-core?platform=linux-bc&channel=beta&version=1.74.20&daily=true&weekly=true&monthly=true&first=false&woi=2024-12-02&dtoi=null&ref=BRV001&adsEnabled=false&arch=&wallet2=0

Image

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Dec 6, 2024
@hffvld
Copy link
Contributor

hffvld commented Dec 6, 2024

Verified on iPhone 14 and iPad Mini (6th gen) using version(s):

Device/OS: 
- iPhone 14 / iOS 17.7.2
- iPad Mini (6th gen) / iPadOS 18.1.1
Brave build: 1.74 (20)
BraveCore: 1.74.20 (131.0.6778.108)

Verified test plan from brave/brave-core#25920 (comment).

NOTE: Will verify this issue again for the referral promo code on the Release build when available in App Store.

Initial ping/Install ping

STEPS:

  1. Have MITM proxy going (Fiddler, etc)
  2. Install and launch 1.74.x
  3. Verify

ACTUAL RESULTS:

  • Verified that https://usage-ping.brave.com call includes first=true in the ping URL:
https://usage-ping.brave.com/1/usage/ios?channel=beta&version=1.74.0&monthly=true&weekly=true&daily=true&first=true&woi=2024-12-02&wallet2=0&ads_enabled=false&dtoi=2024-12-06&ref=ASA1234567890

iPhone 14 iPad Mini (6th gen)
1 2
Daily ping

STEPS:

  1. Continuing from the previous case, close the browser and clear Fiddler/Charles session
  2. Set system date ahead 24h
  3. Relaunch browser
  4. Verify

ACTUAL RESULTS:

  • Verified that https://usage-ping.brave.com call includes daily=true in the ping URL:
https://usage-ping.brave.com/1/usage/ios?channel=beta&version=1.74.0&daily=true&monthly=false&weekly=false&first=false&woi=2024-12-02&wallet2=0&ads_enabled=false&dtoi=2024-12-06&ref=ASA1234567890

iPhone 14 iPad Mini (6th gen)
1 2
Weekly ping

STEPS:

  1. Continuing from the previous case, close the browser and clear Fiddler/Charles session
  2. Set system date ahead 7 days
  3. Relaunch browser
  4. Verify

ACTUAL RESULTS:

  • Verified that https://usage-ping.brave.com call includes weekly=true in the ping URL:
https://usage-ping.brave.com/1/usage/ios?channel=beta&version=1.74.0&weekly=true&daily=true&monthly=false&first=false&woi=2024-12-02&wallet2=0&ads_enabled=false&dtoi=2024-12-06&ref=ASA1234567890

iPhone 14 iPad Mini (6th gen)
1 2
Monthly ping

STEPS:

  1. Continuing from the previous case, close the browser and clear Fiddler/Charles session
  2. Set system date ahead ~28-30 days (so you are in the next month)
  3. Relaunch browser
  4. Verify

ACTUAL RESULTS:

  • Verified that https://usage-ping.brave.com call includes monthly=true in the ping URL:
https://usage-ping.brave.com/1/usage/ios?channel=beta&version=1.74.0&daily=true&monthly=true&weekly=true&first=false&woi=2024-12-02&wallet2=0&ads_enabled=false&dtoi=null&ref=ASA1234567890

iPhone 14 iPad Mini (6th gen)
1 2

@hffvld hffvld added QA Pass - iPhone QA Pass - iPad QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Dec 6, 2024
@hffvld
Copy link
Contributor

hffvld commented Dec 9, 2024

Verified on Galaxy Tab S8 and Pixel 7 using version(s):

Device/OS: 
- Galaxy Tab S8 / gts8wifixx-user 14 UP1A.231005.007 release-keys
- Pixel 7 / panther_beta-user 15 BP11.241025.006 release-keys
Brave build: 1.74.20
Chromium: 131.0.6778.108 (Official Build) beta (64-bit)

Verified test plan from brave/brave-core#25920 (comment).

NOTE: Will verify this issue again for the referral promo code on the Release build when available in App Store.

Initial ping/Install ping

STEPS:

  1. Have MITM proxy going (Fiddler, etc)
  2. Install and launch 1.74.x
  3. Verify

ACTUAL RESULTS:

  • Verified that https://usage-ping.brave.com call includes first=true in the ping URL:
https://usage-ping.brave.com/1/usage/brave-core?platform=android-bc&channel=beta&version=1.74.20&daily=true&weekly=true&monthly=true&first=true&woi=2024-12-09&dtoi=2024-12-09&ref=BRV001&adsEnabled=false&arch=&wallet2=0

Galaxy Tab S8 Pixel 7
1 2
Daily ping

STEPS:

  1. Continuing from the previous case, close the browser and clear Fiddler/Charles session
  2. Set system date ahead 24h
  3. Relaunch browser
  4. Verify

ACTUAL RESULTS:

  • Verified that https://usage-ping.brave.com call includes daily=true in the ping URL:
https://usage-ping.brave.com/1/usage/brave-core?platform=android-bc&channel=beta&version=1.74.20&daily=true&weekly=false&monthly=false&first=false&woi=2024-12-09&dtoi=2024-12-09&ref=BRV001&adsEnabled=false&arch=&wallet2=0

Galaxy Tab S8 Pixel 7
1 2
Weekly ping

STEPS:

  1. Continuing from the previous case, close the browser and clear Fiddler/Charles session
  2. Set system date ahead 7 days
  3. Relaunch browser
  4. Verify

ACTUAL RESULTS:

  • Verified that https://usage-ping.brave.com call includes weekly=true in the ping URL:
https://usage-ping.brave.com/1/usage/brave-core?platform=android-bc&channel=beta&version=1.74.20&daily=true&weekly=true&monthly=false&first=false&woi=2024-12-09&dtoi=2024-12-09&ref=BRV001&adsEnabled=false&arch=&wallet2=0

Galaxy Tab S8 Pixel 7
1 2
Monthly ping

STEPS:

  1. Continuing from the previous case, close the browser and clear Fiddler/Charles session
  2. Set system date ahead ~28-30 days (so you are in the next month)
  3. Relaunch browser
  4. Verify

ACTUAL RESULTS:

  • Verified that https://usage-ping.brave.com call includes monthly=true in the ping URL:
https://usage-ping.brave.com/1/usage/brave-core?platform=android-bc&channel=beta&version=1.74.20&daily=true&weekly=true&monthly=true&first=false&woi=2024-12-09&dtoi=null&ref=BRV001&adsEnabled=false&arch=&wallet2=0

Galaxy Tab S8 Pixel 7
1 2
Feedback ping

STEPS:

  1. Have MITM proxy going (Fiddler, etc)
  2. Install and launch 1.74.x
  3. Hamburger menu > Settings
  4. Support > Rate Brave
  5. Choose a negative face Submit feedback
  6. Verify

ACTUAL RESULTS:

  • Verified that the feedback is sent to https://feedback.brave.com call:
https://feedback.brave.com/1/feedback

Galaxy Tab S8 Pixel 7
1 2

@LaurenWags LaurenWags removed the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Dec 11, 2024
@LaurenWags
Copy link
Member

LaurenWags commented Dec 11, 2024

Added QA/Blocked as this will require an additional check on Windows once we get 1.74.x on the Release channel per #16374 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment