Upstream ClearUndecryptablePasswordsInSync Windows fix

[cdesouza-chromium]

Fixes brave/brave-browser#40091

There has been some issue in chromium, and other browsers, where passwords are being dropped for some users. This is an upstream of a patch pushed to chromium to correct this issue on windows.

Chromium change:
https://chromium.googlesource.com/chromium/src/+/641093c7627684a6c04986531209783f430fb205

commit 641093c7627684a6c04986531209783f430fb205
Author: Viktor Semeniuk <[email protected]>
Date:   Thu Jul 25 16:45:55 2024 +0000

    Enable ClearUndecryptablePasswordsInSync on Windows

    This feature has to be enabled together with SkipUndecryptablePasswords
    otherwise user won't be able to enable sync if they have undecryptable
    passwords.

    Bug: 354847250

Resolves

Submitter Checklist:

• I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally:
  • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
  • npm run presubmit wiki, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

See brave/brave-browser#40091

[bsclifton]

NOTE: this may help partially resolve brave/brave-browser#33548

Although that does happen on macOS also

[github-actions]

The security team is monitoring all repositories for certain keywords. This PR includes the word(s) "password" and so security team members have been added as reviewers to take a look.

No need to request a full security review at this stage, the security team will take a look shortly and either clear the label or request more information/changes.

Notifications have already been sent, but if this is blocking your merge feel free to reach out directly to the security team on Slack so that we can expedite this check.

[emerick]

Can we just add the issue to the description?

[bsclifton]

Created and linked issue brave/brave-browser#40091

[kjozwiak]

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.70.36 Chromium: 127.0.6533.73 (Official Build) nightly (64-bit)
-- | --
Revision | 23e4fbbe30cb67e7592dbf19501231ddad555b2e
OS | Windows 11 Version 23H2 (Build 22631.3958)

Using the STR/Cases via brave/brave-browser#40091 (comment), ensured that the decryptable passwords are being restored once Sync has been enabled and Passwords is toggled on via Sync:

Example	Example	Example	Example	Example

[Saoiray]

@bsclifton and @kjozwiak I stumbled across this but also notice it only mentions Windows. Will this also not affect people on Mac and Linux who have had the same issue? Or is that going to need a different fix?

Also, when should this land? Assuming today?

[bsclifton]

@Saoiray this landed today with version 1.68.134. As you noticed, it only affects Windows.

We're tracking the larger issue with brave/brave-browser#33548 - you can check there for updates 😄