-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstream ClearUndecryptablePasswordsInSync
Windows fix
#24853
Upstream ClearUndecryptablePasswordsInSync
Windows fix
#24853
Conversation
There has been some issue in chromium, and other browsers, where passwords are being dropped for some users. This is an upstream of a patch pushed to chromium to correct this issue on windows. Chromium change: https://chromium.googlesource.com/chromium/src/+/641093c7627684a6c04986531209783f430fb205 commit 641093c7627684a6c04986531209783f430fb205 Author: Viktor Semeniuk <[email protected]> Date: Thu Jul 25 16:45:55 2024 +0000 Enable ClearUndecryptablePasswordsInSync on Windows This feature has to be enabled together with SkipUndecryptablePasswords otherwise user won't be able to enable sync if they have undecryptable passwords. Bug: 354847250
NOTE: this may help partially resolve brave/brave-browser#33548 Although that does happen on macOS also |
The security team is monitoring all repositories for certain keywords. This PR includes the word(s) "password" and so security team members have been added as reviewers to take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just add the issue to the description?
Created and linked issue brave/brave-browser#40091 |
Verification PASSED on
Using the STR/Cases via brave/brave-browser#40091 (comment), ensured that the
|
@bsclifton and @kjozwiak I stumbled across this but also notice it only mentions Windows. Will this also not affect people on Mac and Linux who have had the same issue? Or is that going to need a different fix? Also, when should this land? Assuming today? |
@Saoiray this landed today with version 1.68.134. As you noticed, it only affects Windows. We're tracking the larger issue with brave/brave-browser#33548 - you can check there for updates 😄 |
Fixes brave/brave-browser#40091
There has been some issue in chromium, and other browsers, where passwords are being dropped for some users. This is an upstream of a patch pushed to chromium to correct this issue on windows.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/641093c7627684a6c04986531209783f430fb205
Resolves
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
See brave/brave-browser#40091