Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passwords not showing for some Windows users who have sync enabled #40091

Closed
3 of 6 tasks
rebron opened this issue Jul 29, 2024 · 1 comment · Fixed by brave/brave-core#24853
Closed
3 of 6 tasks
Assignees
Labels
Chromium/reported upstream Issue has been reported upstream and crbug link is in the issue feature/password-manager OS/Desktop OS/Windows priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/No release-notes/include repros-on-chrome

Comments

@rebron
Copy link
Collaborator

rebron commented Jul 29, 2024

Test plan

STR (fresh profile) — e.g. with Beta:

  1. Launch Brave
  2. go to brave://password-manager/passwords
  3. add two passwords:
    • password 1 (can be any site; aaaaa.com for example)
      • Site: aaaaa.com
      • Username: aaaaa
      • Password: aaaaa
    • password 2 (can be any site; bbbbb.com for example)
      • Site: bbbbb.com
      • Username: bbbbb
      • Password: bbbbb
  4. close the browser
  5. open %LOCALAPPDATA%\BraveSoftware\Brave-Browser\User Data\Default\Login Data in DB Browser for SQLite
  6. go to Execute SQL
  7. paste UPDATE logins SET password_value = x'7631301f2bb0cc71024cedf754d0992d32' WHERE username_value='aaaaa', hit F5 and then Ctrl + S
  8. Launch Brave - you'll notice that both passwords are not being listed via brave://password-manager/passwords
  9. enable Brave Sync via brave://settings/braveSync (don't need to pair a device/just enable Sync)
  10. once Sync has been enabled, ensured that Password is enabled via brave://settings/braveSync/setup
  11. restart the browser and you'll notice that the decryptable are now being listed

Description

Starting with 1.68.128 127.0.6533.73 and affected Operating Systems: Windows (10.0.19045, 10.0.22631)

Users are missing passwords from the Password Manager after the latest update. There does not appear to be a country-specific trend.

Chromium issue: https://issues.chromium.org/issues/354847250?pli=1

Steps to reproduce

  1. Launch Brave
  2. Goto brave://password-manager/passwords
  3. Observe password list
  4. Try to sign-in or add a password from a site, e.g. facebook or nytimes
  5. Observe no passwords saved

Actual result

Passwords are not saved.

Expected result

Passwords are saved.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.68.128

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

Related issues:
#39980
#33548

@rebron rebron added OS/Desktop Chromium/reported upstream Issue has been reported upstream and crbug link is in the issue repros-on-chrome priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/Yes release-notes/include labels Jul 29, 2024
@rebron rebron added this to the 1.68.x - Release #3 milestone Jul 29, 2024
@bsclifton bsclifton changed the title [CR 127] Users report missing passwords in Password Manager Fix passwords not showing for some Windows users who have sync enabled Jul 30, 2024
@bsclifton bsclifton added QA/No and removed QA/Yes labels Jul 30, 2024
@bsclifton
Copy link
Member

Marking as QA/No after talking with @kjozwiak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chromium/reported upstream Issue has been reported upstream and crbug link is in the issue feature/password-manager OS/Desktop OS/Windows priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/No release-notes/include repros-on-chrome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants