fix unreadable shields dropdown on Windows #2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cezaraugusto when asking for reviews of brave-ui sha update, it's useful to put the github diff url in the description so that anyone can see which changes will be brought in, and ensure it's only what's described. I've edited in this one. edit: ...as well as mention the brave-ui PR you want to bring in and the brave-browser issue that is being addressed. |
petemill
approved these changes
May 7, 2019
This was referenced May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates brave-ui dep: brave/brave-ui@210a824...e0aff04 to bring in brave/brave-ui#463
Fix: brave/brave-browser#4213
Test Plan: