Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shields Panel drop downs are blank #4213

Closed
btlechowski opened this issue Apr 24, 2019 · 2 comments · Fixed by brave/brave-core#2378
Closed

Shields Panel drop downs are blank #4213

btlechowski opened this issue Apr 24, 2019 · 2 comments · Fixed by brave/brave-core#2378
Assignees
@cezaraugusto
Labels
feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. OS/Linux OS/Windows priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Milestone
0.64.x - Release ...

Comments

@btlechowski
Copy link

Follow up to #2488

Steps to Reproduce

  1. Clean install
  2. Open interia.pl
  3. Open Shields Panel
  4. Click on 3rd-party cookie blocked to show drop down
    OR
  5. Click on 3rd-party recognition devices blocked to show drop down

Actual result:

Text in the drop down is not visible

Light theme:
image
image

Dark theme:
image

Expected result:

Text in the drop down is visible

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Reproduced on

Brave 0.64.60 Chromium: 74.0.3729.91 (Official Build) beta (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Windows 10 OS Build 17134.523

cc @brave/legacy_qa @cezaraugusto
@btlechowski btlechowski added feature/shields The overall Shields feature in Brave. QA/Yes QA/Test-Plan-Specified regression feature/shields/panel Front-end design and functionality of the Shields panel. labels Apr 24, 2019
@btlechowski btlechowski mentioned this issue Apr 24, 2019
Closed
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Apr 26, 2019
@LaurenWags
Copy link
Member

Could not reproduce on macOS

Brave 0.64.62 Chromium: 74.0.3729.108 (Official Build) beta(64-bit)
Revision daaff52abef89988bf2a26091062160b1482b108-refs/branch-heads/3729@{#901}
OS Mac OS X

@cezaraugusto cezaraugusto self-assigned this May 5, 2019
This was referenced May 7, 2019
Merged
Merged
@cezaraugusto cezaraugusto added this to the 0.66.x - Nightly milestone May 7, 2019
This was referenced May 7, 2019
Merged
Merged
@btlechowski
Copy link
Author

btlechowski commented May 13, 2019 •
edited by srirambv
Loading

Verification passed on

Brave 0.64.75 Chromium: 74.0.3729.131 (Official Build) (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Windows 10 OS Build 17134.523

image
image

Verification passed on

Brave 0.64.75 Chromium: 74.0.3729.131 (Official Build) (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. OS/Linux OS/Windows priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Projects
None yet
Milestone
0.64.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

fix unreadable shields dropdown on Windows brave/brave-core
6 participants
@cezaraugusto @bsclifton @rebron @srirambv @LaurenWags @btlechowski