Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed vpn panel shows in-progress after wakeup when vpn is disconnected #22541

Merged
merged 1 commit into from
Mar 14, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -320,11 +320,15 @@ OSStatus StorePassword(const NSString* password, std::string* error_str) {
NEVPNStatus current_status = [[vpn_manager connection] status];
VLOG(2) << "CheckConnection: " << NEVPNStatusToString(current_status);
switch (current_status) {
case NEVPNStatusReasserting:
// See this link for more details about why this status is ingored.
// https://github.com/brave/brave-browser/issues/29500#issuecomment-1989762108
VLOG(2) << "Ignore NEVPNStatusReasserting";
break;
case NEVPNStatusConnected:
OnConnected();
break;
case NEVPNStatusConnecting:
case NEVPNStatusReasserting:
OnIsConnecting();
break;
case NEVPNStatusDisconnected:
Expand Down
Loading