Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed vpn panel shows in-progress after wakeup when vpn is disconnected #22541

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Mar 12, 2024

fix brave/brave-browser#29500

brave/brave-browser#29500 (comment) explains why this fix is added.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Launch brave on macOS
  2. Connect VPN with turn off Reconnect automatically
  3. Sleep and Wakeup
  4. Check VPN button & panel both have disconnected state

@simonhong simonhong self-assigned this Mar 12, 2024
@simonhong simonhong marked this pull request as ready for review March 12, 2024 12:29
@simonhong
Copy link
Member Author

Kindly ping :)

Copy link
Contributor

@sangwoo108 sangwoo108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry. LGTM 👍

@simonhong simonhong merged commit f766af7 into master Mar 14, 2024
23 checks passed
@simonhong simonhong deleted the vpn_status_inconsistency_macOS branch March 14, 2024 02:36
@github-actions github-actions bot added this to the 1.66.x - Nightly milestone Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When computer enters sleep mode, Brave's VPN status is out of sync with the OS
2 participants