Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Fix #36431: Fix crash on send screen in wallet #22434

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

nuo-xu
Copy link
Contributor

@nuo-xu nuo-xu commented Mar 1, 2024

Resolves brave/brave-browser#36431
SVG image rendering using chromium code now needs a font manager.

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@nuo-xu nuo-xu requested review from Brandon-T and StephenHeaps March 1, 2024 23:22
@nuo-xu nuo-xu self-assigned this Mar 1, 2024
@nuo-xu nuo-xu requested a review from a team as a code owner March 1, 2024 23:22
@nuo-xu nuo-xu changed the title [Wallet/iOS] Fix #36431: Fix crash on send screen [iOS] Fix #36431: Fix crash on send screen Mar 1, 2024
@nuo-xu nuo-xu changed the title [iOS] Fix #36431: Fix crash on send screen [iOS] Fix #36431: Fix crash on send screen in wallet Mar 1, 2024
Copy link
Collaborator

@StephenHeaps StephenHeaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crash is resolved 👍. @nuo-xu is there an open issue for to fix display of this NFT in NFT tab/detail?

@nuo-xu nuo-xu merged commit d95613f into master Mar 6, 2024
19 checks passed
@nuo-xu nuo-xu deleted the bugfix/SVG-Fonts branch March 6, 2024 17:51
@github-actions github-actions bot added this to the 1.65.x - Nightly milestone Mar 6, 2024
brave-builds added a commit that referenced this pull request Mar 6, 2024
brave-builds added a commit that referenced this pull request Mar 6, 2024
@srirambv
Copy link
Contributor

srirambv commented Mar 7, 2024

Verification passed on iPhone 13 with iOS 17.4 running 1.65 (63)

  • Verified steps from issue description
  • Verified no crash when submitting a send transaction
22434.MP4

kjozwiak pushed a commit that referenced this pull request Mar 12, 2024
kjozwiak pushed a commit that referenced this pull request Mar 12, 2024
…x) (#22481)

* Uplift of #22434 (squashed) to release

* Fix deps

---------

Co-authored-by: Brandon T <[email protected]>
@nuo-xu
Copy link
Contributor Author

nuo-xu commented Mar 12, 2024

Crash is resolved 👍. @nuo-xu is there an open issue for to fix display of this NFT in NFT tab/detail?

@StephenHeaps here is the issue brave/brave-browser#36708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when selecting token to send
5 participants