Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when selecting token to send #36431

Closed
srirambv opened this issue Feb 28, 2024 · 2 comments · Fixed by brave/brave-core#22434
Closed

Crash when selecting token to send #36431

srirambv opened this issue Feb 28, 2024 · 2 comments · Fixed by brave/brave-core#22434
Assignees
@nuo-xu
Labels
bug crash feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone X QA/Yes release-notes/exclude
Milestone
1.63.x - Release #5

Comments

@srirambv
Copy link
Contributor

Description:

Crash when selecting token to send

Steps to Reproduce

  1. Install 1.63
  2. Open Account
  3. Select Send from Account screen
  4. Token sheet shows up and browser crashes

Actual result:

Crash.MP4

Expected result:

No crash. Allow user to select token

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easy

Brave Version:

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? NA
  • Can you reproduce this issue with the current build from AppStore? NA

Device details:

iPhone 13 (iOS 17.5)

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?NA
  • Is the issue reproducible on the latest version of Mobile Safari? NA

Additional Information

cc: @StephenHeaps @nuo-xu
@srirambv srirambv added bug crash release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality labels Feb 28, 2024
@srirambv srirambv added this to Web3 Feb 28, 2024
@srirambv srirambv mentioned this issue Feb 28, 2024
Closed
@StephenHeaps StephenHeaps moved this to In Progress in Web3 Mar 1, 2024
@nuo-xu nuo-xu mentioned this issue Mar 1, 2024
Merged
24 tasks
@nuo-xu nuo-xu added the QA/Yes label Mar 1, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Mar 6, 2024
@brave-builds brave-builds added this to the 1.65.x - Nightly milestone Mar 6, 2024
This was referenced Mar 6, 2024
Merged
Merged
@nuo-xu nuo-xu mentioned this issue Mar 9, 2024
Closed
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.63.173 or higher for 1.63.x verification 👍

@kjozwiak kjozwiak mentioned this issue Mar 12, 2024
Closed
26 tasks
@srirambv
Copy link
Contributor Author

Verification passed on iPhone 13 with iOS 17.4 running 1.63 (176)

  • Verified steps from issue description
  • Verified no crash when selecting token to Send
36431.MP4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nuo-xu nuo-xu

Labels
bug crash feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone X QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.63.x - Release #5
Development

Successfully merging a pull request may close this issue.

[iOS] Fix #36431: Fix crash on send screen in wallet brave/brave-core
4 participants
@nuo-xu @kjozwiak @srirambv @brave-builds