Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose BraveWalletP3A to iOS via BraveWalletAPI #21903

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Expose BraveWalletP3A to iOS via BraveWalletAPI #21903

merged 1 commit into from
Feb 5, 2024

Conversation

StephenHeaps
Copy link
Collaborator

Resolves brave/brave-browser#35703

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Can be tested on iOS using branch wallet/p3a: brave/brave-ios@development...wallet/p3a
Will be verified with brave/brave-browser#35981 on iOS.

@StephenHeaps StephenHeaps added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels Feb 5, 2024
@StephenHeaps StephenHeaps self-assigned this Feb 5, 2024
@StephenHeaps StephenHeaps requested a review from a team as a code owner February 5, 2024 16:33
@StephenHeaps StephenHeaps merged commit 92d2be1 into master Feb 5, 2024
20 checks passed
@StephenHeaps StephenHeaps deleted the ios-wallet-p3a branch February 5, 2024 18:55
@github-actions github-actions bot added this to the 1.64.x - Nightly milestone Feb 5, 2024
brave-builds added a commit that referenced this pull request Feb 5, 2024
@brave-builds
Uplift of #21903 (squashed) to beta
59690c6
@brave-builds brave-builds mentioned this pull request Feb 5, 2024
Merged
7 tasks
kjozwiak pushed a commit that referenced this pull request Feb 6, 2024
@brave-builds
Expose BraveWalletP3A to iOS via BraveWalletAPI (uplift to 1.63.x) (#…
a78382e 
…21910)

Uplift of #21903 (squashed) to beta

Co-authored-by: brave-builds <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylehickinson kylehickinson kylehickinson approved these changes

Assignees

@StephenHeaps StephenHeaps

Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Milestone
1.64.x - Release
Development

Successfully merging this pull request may close these issues.

Expose BraveWalletP3A to iOS
2 participants
@StephenHeaps @kylehickinson