Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet: P3A #35981

Closed
nuo-xu opened this issue Jan 19, 2024 · 5 comments · Fixed by brave/brave-core#22067
Closed

Wallet: P3A #35981

nuo-xu opened this issue Jan 19, 2024 · 5 comments · Fixed by brave/brave-core#22067
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone QA/Yes release-notes/exclude

Comments

@nuo-xu
Copy link

nuo-xu commented Jan 19, 2024

Wallet P3A Questions

As an active ETH/SOL/FIL user (that currently has an active account, or previously has had one), how many accounts do you have with a non-zero balance?
Brave.Wallet.ActiveEthAccounts, Brave.Wallet.ActiveSolAccounts and Brave.Wallet.ActiveFilAccounts

  1. 0 accounts
  2. 1 account
  3. 2 accounts
  4. 3 accounts
  5. 4-7 accounts
  6. 8+ accounts

Desktop issue: #25504

If you accessed the Wallet onboarding page this week, where did you stop in the onboarding process?
Brave.Wallet.OnboardingConversion.3

  1. Viewed onboarding splash
  2. Between "Legal stuff" and "Create password"
  3. During "recovery phrase" steps
  4. Completed onboarding after completing "recovery phrase" steps
  5. Completed onboarding after skipping "recovery phrase" steps

If you created a wallet within the last week, did you make a deposit this week?
Brave.Wallet.NewUserBalance

  1. Yes

Both metrics are weekly ephemeral metrics.
Desktop issue: #30292

If you viewed the NFT gallery this week, how many NFTs are displayed in the gallery?
Brave.Wallet.NFTCount

  1. 0
  2. 1 - 4
  3. 5 - 20
  4. More than 20

Did you use the NFT gallery for the first time this week?
Brave.Wallet.NFTNewUser

  1. Yes

As a user that has used the wallet at least once, do you have NFT discovery enabled?
Brave.Wallet.NFTDiscoveryEnabled

  1. No
  2. Yes

Desktop issue: #32315

https://github.com/brave/brave-browser/wiki/P3A

Developer Info

Some stats are tracking internally in core:

N/A on iOS (no extensions on iOS to allow provider overwrites)
Brave.Wallet.DefaultSolanaWalletSetting (N/A on wiki or core)
Brave.Wallet.DefaultWalletSetting (N/A on wiki or core)
Brave.Wallet.EthProvider
Brave.Wallet.SolProvider

@StephenHeaps StephenHeaps self-assigned this Jan 30, 2024
@StephenHeaps StephenHeaps transferred this issue from brave/brave-ios Feb 12, 2024
@StephenHeaps StephenHeaps added feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes QA/Yes OS/iOS Fixes related to iOS browser functionality labels Feb 12, 2024
@brave-builds brave-builds added this to the 1.65.x - Nightly milestone Feb 20, 2024
@kjozwiak
Copy link
Member

@GeetaSarvadnya as per the discussion via https://bravesoftware.slack.com/archives/CHGKGMHDJ/p1710226698445269?thread_ts=1709830656.368599&cid=CHGKGMHDJ, lets run through the iOS case mentioned via brave/brave-core#22360 (comment) on 1.65.x as we initially skipped it to save some time. As per @StephenHeaps, that PR doesn't affect iOS on 1.64.x so we can defer the verification once we start running through 1.65.x.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 17, 2024

Verification PASSED on iPhone 8 version 16.7.7 running Brave Nightly 1.65 (114)

EthAccounts

Case 1: Brave.Wallet.EthTransactionSent = 0_PASSED
Case 1.1: No Eth TransactionSent_PASSED
  1. Clean profile 1.65.x
  2. Go to Settings->Brave Core Switches and enable Brave Wallet Count Test Networks
  3. Go to Settings->Web 3->Networks and enable Show Test Networks switch
  4. Go to Portfolio page and click on Filters and Display settings ->Select Networks
  5. Ensure that test networks are displayed under Test Networks
  6. Enable test networks for ETH/FIL/SOL
  7. Create a Ethereum account in Testnet
  8. Send Eth to Ethereum accounts via https://sepolia-faucet.pk910.de/
  9. Ensured that the Eth appeared in the Ethereum account
  10. Ensure that the Transactions list is empty
  11. Open brave://local-state file and ensured that the metrics Brave.Wallet.EthTransactionSent is not shown as there are no Eth transaction sent
Case 2: Brave.Wallet.EthTransactionSent = 1_PASSED
Case 2: Eth Transaction Sent in past 7 days and exceed 7 days_PASSED
  1. Clean profile 1.65.x
  2. Go to Settings->Brave Core Switches and enable Brave Wallet Count Test Networks
  3. Go to Settings->Web 3->Networks and enable Show Test Networks switch
  4. Go to Portfolio page and click on Filters and Display settings ->Select Networks
  5. Ensure that test networks are displayed under Test Networks
  6. Enable test networks for ETH/FIL/SOL
  7. Create a Ethereum account in Testnet
  8. Send Eth to Ethereum accounts via https://sepolia-faucet.pk910.de/
  9. Ensured that the Eth appeared in the Ethereum account
  10. Ensure that the Transactions list is empty
  11. Create a 2nd Ethereum accounts and send 0.005 Eth to 2nd account
  12. Open 1st Ethereum account and check the Transactions list and ensured that there is one Transactions listed for sending 0.005 to 2nd Eth account
  13. Open brave://local-state file and ensured that the metrics Brave.Wallet.EthTransactionSent response value is 1 as expected
  14. Close the browser and set the system date ahead by 7 days
  15. Relaunch the browser
  16. Open brave://local-state file and ensured that the metrics Brave.Wallet.EthTransactionSent response value is 1 as expected
  17. Close the browser and set the system date ahead by 8 days
  18. Relaunch the browser
  19. Open brave://local-state file and ensured that the metrics Brave.Wallet.EthTransactionSent response value is 0 as expected
  20. Create a 3rd Ethereum accounts and send 0.005 SOL to 3rd account
  21. Open brave://local-state file and ensured that the metrics Brave.Wallet.EthTransactionSent response value is 1 as expected
Example Example Example Example Example Example Example
IMG_4466 IMG_4467 IMG_4468 IMG_4469 IMG_4470 IMG_4471 IMG_4476

Solana accounts:

Case 1: Brave.Wallet.SolTransactionSent = 0_PASSED
Case 1.1: No Sol TransactionSent
  1. Clean profile 1.65.x
  2. Go to Settings->Brave Core Switches and enable Brave Wallet Count Test Networks
  3. Go to Settings->Web 3->Networks and enable Show Test Networks switch
  4. Go to Portfolio page and click on Filters and Display settings ->Select Networks
  5. Ensure that test networks are displayed under Test Networks
  6. Enable test networks for ETH/FIL/SOL
  7. Create a Solana account in Testnet
  8. Send Sol to Solana accounts via https://solfaucet.com/
  9. Ensured that the SOL appeared in the Solana account
  10. Ensure that the Transactions list is empty
  11. Open brave://local-state file and ensured that the metrics Brave.Wallet.SolTransactionSent is not shown as there are no SOL transaction sent
Example Example Example Example Example Example Example
IMG_4472 IMG_4473 IMG_4477 IMG_4478 IMG_4479 IMG_4480
Case 2: Brave.Wallet.SolTransactionSent = 1_PASSED
Case 2.1: Sol Transaction Sent in past 7 days and exceed 7 days_PASSED
  1. Clean profile 1.65.x
  2. Go to Settings->Brave Core Switches and enable Brave Wallet Count Test Networks
  3. Go to Settings->Web 3->Networks and enable Show Test Networks switch
  4. Go to Portfolio page and click on Filters and Display settings ->Select Networks
  5. Ensure that test networks are displayed under Test Networks
  6. Enable test networks for ETH/FIL/SOL
  7. Create a Solana account in Testnet
  8. Send Sol to Solana accounts via https://solfaucet.com/
  9. Ensured that the SOL appeared in the Solana account
  10. Ensure that the Transactions list is empty
  11. Create a 2nd Solana accounts and send 0.005 SOL to 2nd account
  12. Open 1st Solana account and check the Transactions list and ensured that there is one Transactions listed for sending 0.005 to 2nd SOL account
  13. Open brave://local-state file and ensured that the metrics Brave.Wallet.SolTransactionSent response value is 1 as expected
  14. Close the browser and set the system date ahead by 7 days
  15. Relaunch the browser
  16. Open brave://local-state file and ensured that the metrics Brave.Wallet.SolTransactionSent response value is 1 as expected
  17. Close the browser and set the system date ahead by 8 days
  18. Relaunch the browser
  19. Open brave://local-state file and ensured that the metrics Brave.Wallet.SolTransactionSent response value is 0 as expected
Example Example Example Example Example Example Example
IMG_4481 IMG_4482 IMG_4483 IMG_4484 IMG_4485 IMG_4486 IMG_4487

FilecoinAccounts

Case 1: Brave.Wallet.FilTransactionSent = 0_PASSED
Case 1.1: No Fil TransactionSent
  1. Clean profile 1.65.x
  2. Go to Settings->Brave Core Switches and enable Brave Wallet Count Test Networks
  3. Go to Settings->Web 3->Networks and enable Show Test Networks switch
  4. Go to Portfolio page and click on Filters and Display settings ->Select Networks
  5. Ensure that test networks are displayed under Test Networks
  6. Enable test networks for ETH/FIL/SOL
  7. Create a Filecoin account in Testnet
  8. Send Fil to Filecoin accounts via https://faucet.calibnet.chainsafe-fil.io
  9. Ensured that the Fil appeared in the Filecoin account
  10. Ensure that the Transactions list is empty under brave://wallet/crypto/accounts/t1rapzhlhwvpj7tfs6jwphsiqkvq4cdab3efmunaa/transactions
  11. Open brave://local-state file and ensured that the metrics Brave.Wallet.FilTransactionSent is not shown as there are no Fil transaction sent
Example Example Example
IMG_4446 IMG_4447 IMG_4445
Case 2: Brave.Wallet.FilTransactionSent = 1_PASSED
Case 2.1: Sol Transaction Sent in past 7 days and exceed 7 days_PASSED
  1. Clean profile 1.65.x
  2. Go to Settings->Brave Core Switches and enable Brave Wallet Count Test Networks
  3. Go to Settings->Web 3->Networks and enable Show Test Networks switch
  4. Go to Portfolio page and click on Filters and Display settings ->Select Networks
  5. Ensure that test networks are displayed under Test Networks
  6. Enable test networks for ETH/FIL/SOL
  7. Create a Filecoin account in Testnet
  8. Send Fil to Filecoin accounts via https://faucet.calibnet.chainsafe-fil.io/send
  9. Ensured that the Fil appeared in the Filecoin account
  10. Ensure that the Transactions list is empty
  11. Create a 2nd Filecoin accounts and send 0.005 Fil to 2nd account
  12. Open 1st Filecoin account and check the Transactions list and ensured that there is one Transactions listed for sending 0.005 to 2nd Fil account
  13. Open brave://local-state file and ensured that the metrics Brave.Wallet.FilTransactionSent response value is 1 as expected
  14. Close the browser and set the system date ahead by 7 days
  15. Relaunch the browser
  16. Open brave://local-state file and ensured that the metrics Brave.Wallet.FilTransactionSent response value is 1 as expected
  17. Close the browser and set the system date ahead by 8 days
  18. Relaunch the browser
  19. Open brave://local-state file and ensured that the metrics Brave.Wallet.FilTransactionSent response value is 0 as expected
  20. Create a 3rd Filecoin accounts and send 1 Fil to 3rd account
  21. Open brave://local-state file and ensured that the metrics Brave.Wallet.FilTransactionSent response value is 1 as expected
Example Example Example Example Example Example Example
IMG_4448 IMG_4449 IMG_4450 IMG_4451 IMG_4453 IMG_4454 IMG_4445

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 17, 2024

@StephenHeaps: I don't see the metrics Brave.Wallet.EthTransactionSent and Brave.Wallet.SolTransactionSent response value 1 on brave://local-state file even though the ETH/SOL send transactions are made between two accounts. Although this was working fine when I verified the issue on nightly build #36156 (comment). I have restarted the browser couple of times and also waited for enough time but no luck. Currently, the Filecoin transactions are only displayed under brave://local-state file on the version 1.65 (114)

Eth:

Example Example Example Example Example Example Example Example Example Example
IMG_4456 IMG_4457 IMG_4458 IMG_4459 IMG_4460 IMG_4461 IMG_4462 IMG_4463 IMG_4464 IMG_4465

@StephenHeaps
Copy link

@GeetaSarvadnya hmm I just tested using fresh install of v1.65 (144) from Testflight and it seems to be working for me. I see you are sending the transaction on Sepolia Test Network, did you enable the Brave Wallet Count Test Networks switch in settings & restart the app after enabling the switch? 🤔

I tested with Sepolia Test Network transaction prior to video, then a Solana Devnet transaction during recording.

RPReplay_Final1713362159.MP4

@GeetaSarvadnya
Copy link

@StephenHeaps: Thanks, now things are working fine. I have created new profile and enabled the switches as mentioned above and also enabled the test network via wallet settings, this time I have funded ETH/SOL wallet via Desktop wallets and then I have transferred the ETH/SOL to 2nd ETH/SOL accounts and I am able to see the response value 1 for the metrics Brave.Wallet.EthTransactionSent and Brave.Wallet.SolTransactionSent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone QA/Yes release-notes/exclude
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants