Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #1825 because of unit test failures #2189

Merged
merged 1 commit into from
Apr 9, 2019

Conversation

bsclifton
Copy link
Member

Unfixes brave/brave-browser#2566
0.64.x specific version of #2188

This reverts commit eba28d0, reversing
changes made to 94401f9.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

Unfixes brave/brave-browser#2566

This reverts commit eba28d0, reversing
changes made to 94401f9.
@bsclifton bsclifton added this to the 0.64.x - Dev milestone Apr 9, 2019
@bsclifton bsclifton requested review from bridiver and simonhong April 9, 2019 23:47
@bsclifton bsclifton self-assigned this Apr 9, 2019
@bsclifton bsclifton merged commit 5fea0f9 into 0.64.x Apr 9, 2019
@bsclifton bsclifton deleted the revert-status-bubble-views-change-0.64.x branch April 9, 2019 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants