Show brave url on status bubble #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SetURL() is called when renderer sent ViewHostMsg_UpdateTargetURL message. So, replacing that url should be done at bubble instead of the middle of that path.
simonhong
force-pushed
the
status_bubble_view_brave_url
branch
from
205c313 to
b418116
Compare
|
kindly ping.. |
mkarolin
approved these changes
Mar 12, 2019
|
@mkarolin Thanks for review 👍 |
bsclifton
added a commit
that referenced
this pull request
Apr 9, 2019
Unfixes brave/brave-browser#2566 This reverts commit eba28d0, reversing changes made to 94401f9.
bsclifton
added a commit
that referenced
this pull request
Apr 9, 2019
Revert #1825 because of unit test failures
bsclifton
added a commit
that referenced
this pull request
Apr 9, 2019
Unfixes brave/brave-browser#2566 This reverts commit eba28d0, reversing changes made to 94401f9.
bsclifton
added a commit
that referenced
this pull request
Apr 9, 2019
…-0.64.x Revert #1825 because of unit test failures
pilgrim-brave
pushed a commit
that referenced
this pull request
Apr 16, 2019
Unfixes brave/brave-browser#2566 This reverts commit eba28d0, reversing changes made to 94401f9.
23 tasks
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SetURL() is called when renderer sent ViewHostMsg_UpdateTargetURL message.
So, replacing that url should be done at bubble instead of the middle of that path.
Fix brave/brave-browser#2566
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
yarn test brave_unit_tests --filter= BraveStatusBubbleViewsTest*Reviewer Checklist: