-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(wallet): migrate to Jupiter API v6 #21475
Conversation
4ec7263
to
1c58797
Compare
A Storybook has been deployed to preview UI for the latest push |
443084c
to
2ad8db7
Compare
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iOS++
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
6ee9a7b
to
32bfe61
Compare
[puLL-Merge] - brave/brave-core@21475 DescriptionThe PR in the review appears to address the implementation of referral program headers and key constants related to the Jupiter swap service feature within the Brave wallet. The main objective seems to be a transition to an updated Jupiter API and adding logic to handle referral keys and program headers as part of the swap transaction request. ChangesChanges
|
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wallet core lgtm
* chore(wallet): migrate to Jupiter API v6 * add referral account to collect platform fees * switch to processed preflight commitment for swaps * review(doug): remove unused dependencies in hook * add production referral key
* chore(wallet): refactor swap service interface (#21406) * chore(wallet): migrate to Jupiter API v6 (#21475) * chore(wallet): migrate to Jupiter API v6 * add referral account to collect platform fees * switch to processed preflight commitment for swaps * review(doug): remove unused dependencies in hook * add production referral key * Fixes BraveWalletUtilsTest Android unit tests --------- Co-authored-by: Serg <[email protected]>
Resolves brave/brave-browser#35091
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Jupiter swaps should work as expected. Note that we don't have multiple quote options in v6 anymore, so we don't surface that it in the UI either.