chore(wallet): refactor swap service interface

[onyb]

No functional changes in this PR, just some refactoring of the SwapService interface.

Resolves brave/brave-browser#34932

Submitter Checklist:

• I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally:
  • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
  • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

N/A

[supermassive]

Let's get address from AccountInfo. Address field in AccountId was/is a temporary measure and to be removed soon™

const fromAccount = useAccountQuery(fromAccountId)
fromAccount.address

[onyb]

Fixed here, but without the useAccountQuery() hook.

[brave-builds]

A Storybook has been deployed to preview UI for the latest push

[brave-builds]

A Storybook has been deployed to preview UI for the latest push

[brave-builds]

A Storybook has been deployed to preview UI for the latest push

[josheleonard]

frontend ++

[brave-builds]

A Storybook has been deployed to preview UI for the latest push

[supermassive]

wallet core LGTM.
Added some minor notes.

[github-actions]

[puLL-Merge] - brave/brave-core@21406

Description

The PR introduces a change in the wallet swap feature within the Brave browser for both Android and Java components. Specifically, it involves refactoring the swap feature's implementation to use a new class name in obfuscation and introduces a new structure to handle swap transaction parameters and responses more generically.

Changes

Changes

android/java/apk_for_test.flags

• Renamed obfuscation class name from SwapParams to SwapQuoteParams to prevent obfuscation on that class as it seems to be required in a readable form for tests.

android/javatests/org/chromium/chrome/browser/brave_wallet/BraveWalletUtilsTest.java

• Refactored unit tests to use the new SwapQuoteParams instead of the old SwapParams.
• Added the new AccountId and RoutePriority imports as they're now required for SwapQuoteParams creation and assertions in tests.

components/brave_wallet/browser/swap_request_helper.cc and .h

• Modified the EncodeJupiterTransactionParams function to take a const reference instead of a pointer, and removed the DCHECK macro call that was checking for a non-null pointer. This suggests a more C++ idiomatic way of handling non-optional parameters and avoiding raw pointers when possible.

components/brave_wallet/browser/swap_request_helper_unittest.cc

• Updated unit tests to reflect the new function signature of EncodeJupiterTransactionParams.
• Deleted DCHECK death tests as they're no longer relevant due to the removal of pointer parameters.

components/brave_wallet/browser/swap_response_parser.cc and .h

• Renamed various functions to better reflect their purpose (ParseSwapResponse was changed to ParseZeroExQuoteResponse, etc.).
• Updated the parameter and return types of various functions to match the new naming and structures introduced in the wallet's swap system.

components/brave_wallet/browser/swap_service.cc

• Updated methods GetPriceQuoteURL and GetTransactionPayloadURL to GetZeroExQuoteURL and GetZeroExTransactionURL, reflecting the switch to the new SwapQuoteParams type.
• Implemented GetTransaction and GetQuote methods to use the new SwapTransactionParamsUnion and SwapQuoteUnion types, offering a more flexible swap service interface that can handle different swap providers and transactions.

components/brave_wallet/common/brave_wallet.mojom

• Added new enums and structs (RoutePriority, SwapQuoteParams, SwapTransactionParamsUnion, SwapQuoteUnion, SwapTransactionUnion, ZeroExQuote, ZeroExErrorItem, ZeroExError).
• Removed old structures that have been superseded by the new types, like SwapParams and SwapResponse.

components/brave_wallet_ui/common/async/__mocks__/bridge.ts

• Updated mock implementations to use the new naming conventions and types (mockZeroExQuote, mockZeroExTransaction).

components/brave_wallet_ui/page/screens/swap/constants/types.ts

• Adjusted SwapParams type definition to replace fromAddress with fromAccount to reflect the new data structure used to represent account information.

components/brave_wallet_ui/page/screens/swap/hooks/useJupiter.ts and useZeroEx.ts

• Refactored the hooks to use the new MOJO union types (SwapTransactionParamsUnion, SwapQuoteUnion), which support handling both Jupiter and ZeroEx swaps in a generic way.

Other Files

• Changes in several files to accommodate the new data types and structures introduced in the MOJO definitions.

Security Hotspots

• Modification of serialization and deserialization logic of transaction parameters could potentially introduce vulnerabilities if not properly handled, creating the risk of malformed transactions or transaction tampering.

Overall, the changes appear to focus on improving the swap system's extensibility, maintainability, and safety by using more robust data types and avoiding raw pointers. The removal of DCHECK macros in favor of using references can also be considered a security and stability improvement, as it enforces the presence of valid objects at compile-time rather than runtime. However, care must be taken to ensure serialization and deserialization routines are robust and secure.

[brave-builds]

A Storybook has been deployed to preview UI for the latest push

[simoarpe]

👍 Java parts look good!

[nuo-xu]

iOS++