Upgrade from Chromium 118 to Chromium 119 #20314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CI/run-network-audit
cdesouza-chromium
force-pushed
the
cr119
branch
6 times, most recently
from
459ec7f to
df32c07
Compare
emerick
force-pushed
the
cr119
branch
2 times, most recently
from
6ee707f to
bc1939a
Compare
cdesouza-chromium
force-pushed
the
cr119
branch
8 times, most recently
from
fcd6e0e to
b5a30ae
Compare
|
No top level dependency changes detected. Learn more about Socket for GitHub ↗︎ |
emerick
force-pushed
the
cr119
branch
2 times, most recently
from
0c1f173 to
9bb86bd
Compare
cdesouza-chromium
force-pushed
the
cr119
branch
2 times, most recently
from
0645a76 to
6664545
Compare
cdesouza-chromium
force-pushed
the
cr119
branch
from
d48b81a to
cb6d2aa
Compare
Functions on `LoginDatabase` are now passing `PasswordForm` by value. This change corrects our use of it, and make the code around it to use references when referring to `PasswordForm` instances for better readability. Chromium change: https://chromium.googlesource.com/chromium/src/+/1de3dd85f6076a1bf816a16a2fe0617d6739df1f commit 1de3dd85f6076a1bf816a16a2fe0617d6739df1f Author: Viktor Semeniuk <[email protected]> Date: Fri Sep 29 09:01:04 2023 +0000 Replacing unique_ptr<PasswordForm> with PasswordForm in login database Bug: 1484572
Chromium change: https://source.chromium.org/chromium/chromium/src/+/84bb7029b5ddf825bd30054534a8be9c95b8ed07 commit 84bb7029b5ddf825bd30054534a8be9c95b8ed07 Author: Peter Kasting <[email protected]> Date: Thu Sep 28 21:32:28 2023 +0000 Remove Windows-specific wstring variants of StringPrintf() etc. This should allow us to begin converting use of StringPrintf() to absl::StrFormat(). Bug: 1371963
brave/chromium@4196563 Rename SiteSettingsPreferenceFragment Bug: 1485637
This setting was flipped to enabled upstream and began interfering with ephemeral storage. Chromium change: https://source.chromium.org/chromium/chromium/src/+/f5d8c2cc44071d4e5e42a0db9ed8663ac90bd533 commit f5d8c2cc44071d4e5e42a0db9ed8663ac90bd533 Author: Kyra <[email protected]> Date: Thu Sep 28 02:01:16 2023 +0000 Enabling ThirdPartyStoragePartitioning by default We have received launch approvals for Stable 100% and Enabled-By-Default for ThirdPartyStoragePartitioning. We are not launching on Android WebView right now, so we added an override to AwFieldTrials. Bug: 1434690
Chromium change: brave/chromium@d2cf18e [Android] Move SharedPreferencesManager to //base SharedPreferencesManager only needed to be //chrome-layer because it has lists of the SharedPrefs keys used in Chrome. This CL: - Detaches the key registry from the key checking - Moves SharedPreferencesManager and Base/ChromePreferenceKeyChecker to //base - Leaves behind a temporary facade where //chrome SharedPreferencesManager is until the migration is finished. - Implements checking that all PreferenceKeyRegistries are listed in AllPreferenceKeyRegistries - Modifies ChromePreferenceKeysTest to check uniqueness across all known registries See go/base-shared-preferences for more details. Bug: 1069897,1483469
Chromium change: brave/chromium@da4dc78 Privacy Guide: 100% Stable launch - Enable feature flag(s) by default. - Remove the PrivacyGuideAndroid field trial config. - Keep the PrivacyGuideAndroid3 field trial config separate. Bug: 1238896
Chromium change: https://source.chromium.org/chromium/chromium/src/+/8d32c9a197581cadc78fa93c806e04053861b182 commit 8d32c9a197581cadc78fa93c806e04053861b182 (tag: 119.0.6045.16) Author: Lily Chen <[email protected]> Date: Tue Oct 10 00:05:56 2023 +0000 [M119][DownloadBubble] Fix icon bugs introduced in crrev.com/c/4904720 This fixes 2 user-visible bugs that regressed in crrev.com/c/4904720. 1. The animated scanning ring for deep scans disappeared. It is restored by always forcing a redraw of the progress ring if we need to show the scanning animation. 2. Any update to the progress requiring a redraw of the progress ring was not processed until the subsequent update call, resulting in an inconsistent icon state for the first 0.5 seconds. This is fixed by calling UpdateIcon only after redraw_progress_soon_ is set. (cherry picked from commit da92f2fa4190f6513b40c8d032b98d58fe0a8877) Bug: 1487569
This reverts commit ec910d2.
Chromium change: https://source.chromium.org/chromium/chromium/src/+/5f7858ba874b7339f9fdadd1b54f3a13e23ab0f4 commit 5f7858ba874b7339f9fdadd1b54f3a13e23ab0f4 Author: Marc Treib <[email protected]> Date: Mon Sep 11 15:42:55 2023 +0000 History Sync cleanup: Simplify HistoryModelTypeController This controller used to be used for both HISTORY and TYPED_URLS. Now TYPED_URLS is gone, allowing for some simplification. Bug: 1365291
cdesouza-chromium
force-pushed
the
cr119
branch
from
49d8e16 to
a58caef
Compare
github-actions
bot
added
CI/storybook-url
25 tasks
emerick
added a commit
that referenced
this pull request
Oct 25, 2023
Upgrade from Chromium 118 to Chromium 119
kjozwiak
pushed a commit
that referenced
this pull request
Oct 26, 2023
* Enable History datatype for Sync (#20329) * Reverted PR#16705 (Sync all history) * Reverted PR#16478 (Display history sync diagnostic info) * Reverted PR#20071 (Disable history sync datatype to fallback to typed urls datatype) * Added overrides for HistoryModelTypeController and HistoryDeleteDirectivesModelTypeController to work when encrypt everything option is on * Add patch to sync history delete directives and history entities together * Added unit test for LowPriorityUserTypes * Enable encryption of history sync entities * Added test for precondition state of history datatype controllers * Modified: clean out HistoryDeleteDirectiveSpecifics::UrlDirective::url field, as it is unencrypted * Added test to ensure we don't send url at HistoryDeleteDirectiveSpecifics::UrlDirective * Modified ModelTypeTest.EncryptableUserTypes test to check History type * Removed 'path_excludes' for the files removed in the current PR --------- Co-authored-by: Darnell Andries <[email protected]> * Fix #33746: Cleanup Brave-Core iOS chromium_src overrides & initialization code (#20598) - Cleanup Brave-Core IOS Chromium_SRC overrides. - Add new cleaner Chromium_SRC overrides and simplify app launch logic. * Don't redefine static_assert (#20440) (Instead, we make sure the static_assert passes here by locally restoring kCoarseResolutionMicroseconds back to its original Chromium value.) * Use `PrefService` with `MigrateObsoleteProfilePrefs` (#20396) Upstream is changing `MigrateObsoleteProfilePrefs` to take a `PrefService` pointer, rather than `Profile`, as this is more expressive of the data actually being accessed. This change aligns all places where we have procedures similar to `MigrateObsoleteProfilePrefs`, to receive a `PrefService*` instance as well. Chromium change: https://chromium.googlesource.com/chromium/src/+/d848587fe1f19123940de4e4c0cec328bc23001f commit d848587fe1f19123940de4e4c0cec328bc23001f Author: Mikel Astiz <[email protected]> Date: Mon Oct 2 09:28:03 2023 +0000 [sync] Remove legacy SyncRequested pref It has been practically unused for some time, and most of it is dead code ever since the feature toggle was cleaned up in https://crrev.com/c/4886256. On Ash, it needs to be migrated to a newly-introduced preference tailored to the actual underlying need, which is being able to remember that the server returned DISABLE_SYNC_ON_CLIENT (i.e. the user reset sync via dashboard). Change-Id: I0239447173b32d7d007ebf733dde23a5de1859e1 Bug: 1443446, 1219990 * Ignore formatting for crates under `third_party` (#20390) This changes adds a patch to add brave's own third party crates path to the list of rust paths to be ignored during formatting. * Merge pull request #20642 from brave/ios/bugfix/sync_all_history * Merge pull request #20664 from brave/cr119-followup-disable-power-bookmarks Disable kPowerBookmarksSidePanel feature flag * [Android] Fix for private tab badge padding Chromium change: https://source.chromium.org/chromium/chromium/src/+/37d04b2089c15cb152a8a559887a7d10c66572be [APS] Update tooltip visibility and remove hover highlight for StatusView - Remove tooltip when StatusIconView is not visible. - remove hover highlight when StatusIconView is not visible(e.g. default engine is not Google). - remove hover highlight when VerboseStatusText is visible(e.g. offline). demo(default engine not Google): https://drive.google.com/file/d/1DPIhHtWN4RnjPvkysyCSfV_gd73ZMjPb/view?usp=sharing demo(offline) https://drive.google.com/file/d/1-1Y_t59i8AcxFv6sLpBE-kG2tsSGoi4s/view?usp=sharing TODO: relocate the logic in StatusView to StatusViewBinder or StatusProperties. Bug: 1476816, 1476802 * Merge pull request #20314 from brave/cr119 Upgrade from Chromium 118 to Chromium 119 --------- Co-authored-by: AlexeyBarabash <[email protected]> Co-authored-by: Darnell Andries <[email protected]> Co-authored-by: Brandon-T <[email protected]> Co-authored-by: Arthur Edelstein <[email protected]> Co-authored-by: cdesouza-chromium <[email protected]> Co-authored-by: Soner YUKSEL <[email protected]> Co-authored-by: Artem Samoilenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#33274
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: