Skip to content

Commit

Permalink
UpdateIconProgress method was removed
Browse files Browse the repository at this point in the history
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/8d32c9a197581cadc78fa93c806e04053861b182

commit 8d32c9a197581cadc78fa93c806e04053861b182 (tag: 119.0.6045.16)
Author: Lily Chen <[email protected]>
Date:   Tue Oct 10 00:05:56 2023 +0000

    [M119][DownloadBubble] Fix icon bugs introduced in crrev.com/c/4904720

    This fixes 2 user-visible bugs that regressed in crrev.com/c/4904720.

    1. The animated scanning ring for deep scans disappeared. It is restored
       by always forcing a redraw of the progress ring if we need to show
       the scanning animation.

    2. Any update to the progress requiring a redraw of the progress ring
       was not processed until the subsequent update call, resulting in an
       inconsistent icon state for the first 0.5 seconds. This is fixed by
       calling UpdateIcon only after redraw_progress_soon_ is set.

    (cherry picked from commit da92f2fa4190f6513b40c8d032b98d58fe0a8877)

    Bug: 1487569
  • Loading branch information
emerick authored and cdesouza-chromium committed Oct 12, 2023
1 parent 4e96d32 commit 6664545
Showing 1 changed file with 3 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,9 @@ class FakeDownloadDisplay : public DownloadDisplay {
if (updates.new_active) {
active_ = *updates.new_active;
}
}

void UpdateIconProgress(const ProgressInfo& info) override {
progress_info_ = info;
if (updates.new_progress) {
progress_info_ = *updates.new_progress;
}
}

void ShowDetails() override { detail_shown_ = true; }
Expand Down

0 comments on commit 6664545

Please sign in to comment.