Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove HTTPS Everywhere #19779

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Remove HTTPS Everywhere #19779

merged 1 commit into from
Oct 28, 2023

Conversation

arthuredelstein
Copy link
Collaborator

@arthuredelstein arthuredelstein commented Aug 19, 2023 •
edited
Loading

Resolves brave/brave-browser#28433

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@arthuredelstein arthuredelstein requested review from a team and iefremov as code owners August 19, 2023 00:16
@arthuredelstein arthuredelstein marked this pull request as draft August 19, 2023 00:16
@github-actions github-actions bot added CI/run-network-audit Run network-audit potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false CI/storybook-url Deploy storybook and provide a unique URL for each build labels Aug 19, 2023
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@arthuredelstein arthuredelstein marked this pull request as ready for review August 19, 2023 05:22
@iefremov
Copy link
Contributor

iefremov commented Sep 4, 2023

@arthuredelstein is it ready for review?

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@arthuredelstein
Copy link
Collaborator Author

@iefremov wrote:

@arthuredelstein is it ready for review?

Yes, it's ready now. Thanks!

antonok-edm
antonok-edm reviewed Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@antonok-edm antonok-edm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

test/data/https-everywhere-data/
test/data/https-everywhere-data.pem

should be safe to remove too?

@arthuredelstein
Copy link
Collaborator Author 

test/data/https-everywhere-data/
test/data/https-everywhere-data.pem

should be safe to remove too?

Thanks -- done.

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@arthuredelstein arthuredelstein requested review from a team and antonok-edm October 12, 2023 17:28
@iefremov
Copy link
Contributor

would be great to write code that will actually remove the httpse db from disk (i.e. the entire component directory)

@iefremov
Copy link
Contributor

also when merged we can won'tfix related httpse tickets :)

@arthuredelstein arthuredelstein requested review from a team as code owners October 25, 2023 23:12
@antonok-edm antonok-edm mentioned this pull request Oct 25, 2023
Closed
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@antonok-edm antonok-edm mentioned this pull request Oct 26, 2023
Merged
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@arthuredelstein arthuredelstein enabled auto-merge (squash) October 27, 2023 02:58
@arthuredelstein arthuredelstein enabled auto-merge (squash) October 27, 2023 03:50
mkarolin
mkarolin approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

SergeyZhukovsky
SergeyZhukovsky approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@arthuredelstein arthuredelstein enabled auto-merge (squash) October 27, 2023 23:33
@arthuredelstein
Copy link
Collaborator Author

Thanks for the reviews!

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@arthuredelstein arthuredelstein merged commit bccdc83 into master Oct 28, 2023
6 checks passed
@arthuredelstein arthuredelstein deleted the issues/28433 branch October 28, 2023 05:29
@github-actions github-actions bot added this to the 1.62.x - Nightly milestone Oct 28, 2023
@davidcollini
Copy link

davidcollini commented Oct 28, 2023 •
edited
Loading

Finally!🙌

Great work everyone🫶

@MadhaviSeelam
Copy link

@arthuredelstein can you attach a testplan please?

@arthuredelstein
Copy link
Collaborator Author

arthuredelstein commented Nov 8, 2023 •
edited
Loading

@MadhaviSeelam Please see brave/brave-browser#28433 (comment)

mherrmann pushed a commit that referenced this pull request Nov 9, 2023
@arthuredelstein @mherrmann
Remove HTTPS Everywhere (#19779)
d155fcc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkarolin mkarolin mkarolin approved these changes

@antonok-edm antonok-edm antonok-edm approved these changes

@SergeyZhukovsky SergeyZhukovsky SergeyZhukovsky approved these changes

@iefremov iefremov iefremov approved these changes

@bridiver bridiver Awaiting requested review from bridiver bridiver is a code owner

Assignees

@arthuredelstein arthuredelstein

Labels
CI/run-network-audit Run network-audit CI/storybook-url Deploy storybook and provide a unique URL for each build potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Milestone
1.62.x - Release
Development

Successfully merging this pull request may close these issues.

Remove obsolete HTTPS Everywhere list from Brave since it's no longer needed
9 participants
@arthuredelstein @brave-builds @iefremov @davidcollini @MadhaviSeelam @bridiver @SergeyZhukovsky @antonok-edm @mkarolin