[Android] default filter list settings

[tapanmodh]

Resolves brave/brave-browser#26587

Submitter Checklist:

• I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally:
  • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
  • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

1. Open settings
2. Go to Brave Shields & privacy
3. Go to Content Filtering
4. You can enable disable default filter list

[mkarolin]

strings++

[deeppandya]

LGTM

[samartnik]

lgtm

[antonok-edm]

I'm concerned about calling these "default" filter lists, since they are generally off by default. We already reserve that naming for the on-by-default lists (although we don't show it in the UI anywhere).

These lists come from the "regional list catalog"^†. Ever since brave://adblock was replaced by brave://settings/shields/filters on Desktop, they're just labeled "Filter lists".

My recommendation is to follow the naming on Desktop (Filter lists). The title of the overall settings page can also be renamed to match accordingly (Content Filters). I'd also update the code to refer to them as "regional lists" (e.g. FilterListService::GetRegionalFilterLists).

---

† which is no longer only for "regional" lists, to make things even more confusing 😂
this needs some refactoring, but it'll be easier to do it all at once if the naming is consistent in the code.

[tapanmodh]

@timchilds @deeppandya what do you think? Should we follow the desktop or ios?

[timchilds]

Following desktop makes sense to me. @anthonypkeane what do you think?

[deeppandya]

I agree we should remove the default and just keep the filter list as a copy.

[SergeyZhukovsky]

++

[kjozwiak]

Verification PASSED on Pixel 6 running Android 14 using the following build(s):

Brave | 1.60.56 Chromium: 117.0.5938.92 (Official Build) canary (64-bit)
--- | ---
Revision | 3b7f9ca8094bbdada8e04aa8531f4bd9becbc25b
OS | Android 14; Build/UPB5.230623.009; 34; REL

Using the STR/Cases outlined via #19670 (comment) and the information outlined via brave/brave-browser#26587, ensured the following:

• ensured that the default filter list is visible via Settings -> Brave Shields & privacy -> Content Filtering
  • checked using both Dark & Light themes as well
• disabled/enabled Fanboy's Mobile Notifications via Settings -> Brave Shields & privacy -> Content Filtering
  • ensured that the Open with modal appears within reddit.com once the filter is disabled (proving that filters are working)
  • ensured that the Open with modal is NOT appearing once Fanboy's Mobile Notifications is re-enabled
• compared the default filter list between 1.58.131 via brave://adblock and 1.60.56viaContent Filtering` settings
  • basically ensured that we're not missing any entries when we moved into the native implementation
• ensured that the settings persist after restarting (stay enabled/stay disabled etc..)
• ensured that enabling/disabling the default filter list via the toggles doesn't crash Brave

Example	Example	Example	Example	Example	Example