Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Content filtering via settings #26587

Closed
timchilds opened this issue Nov 7, 2022 · 2 comments · Fixed by brave/brave-core#19670
Closed

[Android] Content filtering via settings #26587

timchilds opened this issue Nov 7, 2022 · 2 comments · Fixed by brave/brave-core#19670
Assignees
Labels
feature/shields The overall Shields feature in Brave. feature-request OS/Android Fixes related to Android browser functionality privacy/discussed Discussed in privacy confab privacy/feature User-facing privacy- & security-focused feature work. QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android 8+ QA/Test-All-Platforms QA/Yes release-notes/include

Comments

@timchilds
Copy link

timchilds commented Nov 7, 2022

Description

Currently users can enable/disable content filtering lists via settings on iOS and Desktop. This ticket is to bring over the same feature to Android.

Desktop Feature iOS Feature
image image

Requirements

  • Android users are able to enable/disable individual content filtering lists via settings.
  • The setting should live under Brave Shields & privacy, after the "prevent fingerprinting via language settings" toggle.

Design

We should do the same as iOS, a screen with a list of toggles. @Sam-Sibley @deeppandya I don't think we need any designs here. We can just re-use the screen we have for Brave News -> All Sources. Let me know if you think otherwise?

image

@timchilds timchilds added OS/Android Fixes related to Android browser functionality QA/Yes release-notes/include privacy/feature User-facing privacy- & security-focused feature work. feature/shields The overall Shields feature in Brave. feature-request labels Nov 7, 2022
@ShivanKaul ShivanKaul added the privacy/discussed Discussed in privacy confab label Nov 29, 2022
@timchilds timchilds changed the title [Android] Content Filtering via settings [Android] Content filtering via settings Mar 9, 2023
@brave-builds brave-builds added this to the 1.60.x - Nightly milestone Sep 13, 2023
@kjozwiak
Copy link
Member

kjozwiak commented Sep 25, 2023

The above requires 1.59.100 or higher for 1.59.x verification 👍 Adding QA/Test-All-Platforms as we'll want to double check on the Tablet and ensure that everything is being displayed correctly on the larger form factor.

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 3, 2023
@hffvld
Copy link
Contributor

hffvld commented Oct 4, 2023

Verified on Pixel 2 XL, Galaxy Tab S8 and Pixel 7 using version(s):

Device/OS: 
- Pixel 2 XL [taimen-user  8.1.0 OPM2.171026.006.H1 release-keys]
- Galaxy Tab S8 [gts8wifixx-user 13 TP1A.220624.014 release-keys]
- Pixel 7 [panther_beta-user 14 U1B1.230908.003 release-keys]
Brave build: 1.59.109
Chromium: 118.0.5993.21 (Official Build) beta (64-bit) 
Revision: aacb6a6f8bd916bd49f064b2137b007fa6c47b51

STEPS:

  1. Followed the steps from [Android] default filter list settings brave-core#19670 (comment)

ACTUAL RESULTS:

  • Verified that the default filter list is visible via Settings > Brave Shields & privacy > Content Filtering
    • Checked using both Dark and Light Mode
  • Verified that disabling/enabling Fanboy's Mobile Notifications via Settings > Brave Shields & privacy > Content Filtering is working
    • Verified that the Open with modal appears within reddit.com once the filter is disabled (proving that filters are working)
    • Verified that the Open with modal is NOT appearing once Fanboy's Mobile Notifications is re-enabled
  • Compared the default filter list between 1.58.135 via brave://adblock and 1.59.102 via Content Filtering settings
    • Verified that we're not missing any entries when we moved into the native implementation
  • Verified that the settings persist after restarting (stay enabled/stay disabled etc.)
  • Verified that enabling/disabling the default filter list via the toggles doesn't crash Brave

Pixel 2 XL / Android 8

1 2 3 4
1 2 3
1 2 3

Galaxy Tab S8 / Android 13

1 2 3 4
1 2 3 4
1 2 3 4

Pixel 7 / Android 14

1 2 3 4
1 2 3 4
1 2 3 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields The overall Shields feature in Brave. feature-request OS/Android Fixes related to Android browser functionality privacy/discussed Discussed in privacy confab privacy/feature User-facing privacy- & security-focused feature work. QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android 8+ QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants