-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable copy-clean-link-by-default for osx #17752
Conversation
c3c120f
to
ce0ca10
Compare
5ab750b
to
fe7641c
Compare
fe7641c
to
92e57ed
Compare
Verified with
macOS - PASSEDConfirmed with prior version (1.51.51 via #17673 (comment)), that default for brave://flags/#brave-copy-clean-link-by-default was enabled. Using 1.51.64, confirmed default for brave://flags/#brave-copy-clean-link-by-default was disabled: Case A: Ran through appropriate cases on https://fmarier.github.io/brave-testing/copy-clean-link.html to confirm functionality still works with the keyboard shortcut disabled. (spot check of "Copy clean link" functionality) Case B: Ran through the below steps to confirm expected locations of "Copy clean link" option and confirm that keyboard shortcut (Cmd + C on macOS) is not used for "Copy clean link":
Windows - PASSEDSpot checked that the default for brave://flags/#brave-copy-clean-link-by-default was enabled.
Linux - PASSEDSpot checked that the default for brave://flags/#brave-copy-clean-link-by-default was enabled.
|
Uplift of #17752 (squashed) to beta
Resolves brave/brave-browser#29303
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: