-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap clean link to a feature flag #17673
Conversation
b710a99
to
7eb5671
Compare
7eb5671
to
e66e153
Compare
Verified with
Confirmed flag is available with Default - PASSEDRan through the below steps to confirm expected locations of "Copy clean link" option from macOS app menu, context menu, share menu, and keyboard shortcut (Cmd + C on macOS):
Disabled - PASSEDCase A: Ran through appropriate cases on https://fmarier.github.io/brave-testing/copy-clean-link.html to confirm functionality still works with the keyboard shortcut disabled. (spot check of "Copy clean link" functionality) Case B: Ran through the below steps to confirm expected locations of "Copy clean link" option and confirm that keyboard shortcut (Cmd + C on macOS) is not used for "Copy clean link":
Enabled - PASSEDCase A: Ran through appropriate cases on https://fmarier.github.io/brave-testing/copy-clean-link.html to confirm functionality works as expected with the keyboard shortcut enabled. (spot check of "Copy clean link" functionality) Case B: Ran through the below steps to confirm expected locations of "Copy clean link" option and confirm that keyboard shortcut (Cmd + C on macOS) is used for "Copy clean link":
|
Resolves brave/brave-browser#29177
Ctrl+C
hotkey and it copies sanitized url.Ctrl+C
hotkey and it copies url as usual.Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Ctrl+C
default hotkeyCtrl+C
hotkey