-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookie exception to unbreak Google logins #1748
Conversation
Please link in the PR to the issue this is fixing (creating an issue if one doesn't exist already) and squash commits into one commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest adding two test cases in common/shield_exceptions_unittest.cc
:
-
A positive test case:
EXPECT_TRUE(IsWhitelistedCookieException(GURL("https://www.airbnb.com/"), GURL("<actual Google URL used AirBnB uses minus query string>")));
-
A negative test case:
EXPECT_FALSE(IsWhitelistedCookieException(GURL("https://www.mozilla.org/"), GURL("https://www.googletagmanager.com/gtm.js")));
2c78205
to
e0a51c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit message (and this PR as @diracdeltas pointed out) is missing a link to the issue that it is fixing.
Other than that, it looks good to me.
e0a51c4
to
c9c8212
Compare
Oh sorry, I wasn't familiar with the formatting expectations and thought the above reference to brave/brave-browser#3115 was enough. Made a more generic issue to link this to, referenced it in the description, and also re-pushed the changes with a more appropriate message. |
In the commit messages, the syntax also requires |
c9c8212
to
ee53f9a
Compare
This was added here ec009bb as part of an option that can be disabled. Closing this PR. |
Fixes brave/brave-browser#3534.
This PR wires in the already existing cookie exception checking method to the cookie blocking workflow, adds capability for 1st-party-independent exceptions (e.g., specific iframe hosts that should be allowed to access cookies no matter the hosting site), and adds an exception to
https://accounts.google.com/o/oauth2/*
to allow iframe-based Google login integration on many sites, as per our slack discussions.Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) ongit rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist: