-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some Google login integrations do not work #3534
Labels
feature/shields/cookies
Cookie controls implemented as part of Shields.
priority/P2
A bad problem. We might uplift this to the next planned release.
QA/No
release-notes/exclude
webcompat/shields
Shields is breaking a website.
Milestone
Comments
mrzealot
added
webcompat/shields
Shields is breaking a website.
feature/shields/cookies
Cookie controls implemented as part of Shields.
labels
Feb 28, 2019
18 tasks
mrzealot
pushed a commit
to brave/brave-core
that referenced
this issue
Mar 1, 2019
bbondy
changed the title
Fix certain Google login integrations
Some Google login integrations do not work
Mar 5, 2019
bbondy
added
the
priority/P2
A bad problem. We might uplift this to the next planned release.
label
Mar 5, 2019
bbondy
pushed a commit
to brave/brave-core
that referenced
this issue
Mar 11, 2019
19 tasks
Marking as QA/No since test case for this is covered in #3489 |
bbondy
pushed a commit
to brave/brave-core
that referenced
this issue
Mar 12, 2019
bbondy
pushed a commit
to brave/brave-core
that referenced
this issue
Mar 15, 2019
This was referenced Mar 15, 2019
all of these sites appear to work now without the cookie whitelist preference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/shields/cookies
Cookie controls implemented as part of Shields.
priority/P2
A bad problem. We might uplift this to the next planned release.
QA/No
release-notes/exclude
webcompat/shields
Shields is breaking a website.
Embedded Google login integrations break with shields up. This is due to iframes loading pages from accounts.google.com and not being able to set cookies.
Examples include:
Note that there are numerous other Google login integrations that work just fine because they use a redirect-based authentication instead of the embedded iframes.
The text was updated successfully, but these errors were encountered: