fix(wallet): View Contract in Transaction Panel (uplift to 1.49.x) #17426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is intended to be used to check if an address is an EOA or a contract
You can query
```js
const apiProxy = getWalletPanelApiProxy()
const jsonRpcService = apiProxy.jsonRpcService
console.log('BAT rpc service get code: ', await jsonRpcService.getCode('0x0d8775f648430679a709e98d2b0cb6250d2887ef', BraveWallet.CoinType.ETH, '0x1'))
console.log('EOA rpc service get code: ', await jsonRpcService.getCode('0x...', BraveWallet.CoinType.ETH, '0x1'))
```
This would output the bytecode in hex format for the BAT price and the
string 0x for the EOA address.
github-actions
bot
added
the
CI/storybook-url
fix(wallet): View Contract in Transaction Panel
Douglashdaniel
force-pushed
the
view-contract-in-transaction-panel-1.49.x
branch
from
a75988a to
348559d
Compare
|
A Storybook has been deployed to preview UI for the latest push |
kjozwiak
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
Uplift into 1.49.x approved 👍 QA has verified the PR on Nightly as per #17333 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uplift of #17333
Uplift of #17215
Resolves brave/brave-browser#27188
Resolves brave/brave-browser#28518
Pre-approval checklist:
Pre-merge checklist:
Post-merge checklist: