Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is no way for a user to learn the contract address they are signing a transaction for #27188

Closed
nvonpentz opened this issue Dec 6, 2022 · 4 comments · Fixed by brave/brave-core#17333
Closed

There is no way for a user to learn the contract address they are signing a transaction for #27188

nvonpentz opened this issue Dec 6, 2022 · 4 comments · Fixed by brave/brave-core#17333
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include security
Milestone
1.49.x - Release

Comments

@nvonpentz
Copy link
Member

As far as I can tell, there's no way to copy the contract address from our UI when signing a transaction. As a result, users have no choice but to blindly trust the contract. The frontend should display the full contract address or create a way to copy it so users can look it up before signing.
@diracdeltas
Copy link
Member

can this be prioritized?

@bsclifton bsclifton added this to Web3 Dec 30, 2022
@jamesmudgett jamesmudgett added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 12, 2023
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Jan 12, 2023
@Douglashdaniel Douglashdaniel self-assigned this Jan 12, 2023
@Douglashdaniel Douglashdaniel moved this from Backlog to In Progress in Web3 Jan 12, 2023
@Douglashdaniel Douglashdaniel added the front-end-change This task is a front end task and doesn't need any C++ changes label Jan 12, 2023
@bbondy
Copy link
Member

bbondy commented Feb 15, 2023

The backend side is here: brave/brave-core#17215 @Douglashdaniel will pickup the front end work next.

@Douglashdaniel Douglashdaniel mentioned this issue Feb 22, 2023
Merged
25 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Feb 22, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Feb 23, 2023
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 23, 2023
@Douglashdaniel Douglashdaniel mentioned this issue Mar 1, 2023
Merged
7 tasks
@srirambv srirambv added the QA/Yes label Mar 2, 2023
@kjozwiak
Copy link
Member

kjozwiak commented Mar 2, 2023

The above requires 1.49.118 or higher for 1.49.x verification 👍

@srirambv srirambv mentioned this issue Mar 3, 2023
Open
@srirambv
Copy link
Contributor

srirambv commented Mar 6, 2023

Verification passed on

Brave 1.49.118 Chromium: 111.0.5563.50 (Official Build) (64-bit)
Revision 39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS Linux
  • Verified steps from brave/brave-core#17333
  • Verified when a contract address is used for sign transaction it updates the address to show as contract address
  • Verified clicking on the contract address loads block explorer and sets focus to the code section on the page
  • Encountered #28849
27188.mp4

Verification passed on

Brave 1.49.118 Chromium: 111.0.5563.50 (Official Build) (64-bit)
Revision 39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#17333
  • Verified when a contract address is used for sign transaction it updates the address to show as contract address
  • Verified clicking on the contract address loads block explorer and sets focus to the code section on the page
  • Encountered #28849
27188.mp4

Verification passed on

Brave 1.49.118 Chromium: 111.0.5563.50 (Official Build) (arm64)
Revision 39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#17333
  • Verified when a contract address is used for sign transaction it updates the address to show as contract address
  • Verified clicking on the contract address loads block explorer and sets focus to the code section on the page
  • Encountered #28849
27188.mov

@LaurenWags LaurenWags mentioned this issue Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include security
Projects
Web3
Archived in project
Milestone
1.49.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): View Contract in Transaction Panel brave/brave-core
8 participants
@jamesmudgett @diracdeltas @bbondy @kjozwiak @nvonpentz @srirambv @Douglashdaniel @brave-builds