Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change title case for New private window string #17387

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Feb 27, 2023

Resolves brave/brave-browser#17377

image

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • steps from issue

@spylogsster spylogsster self-assigned this Feb 27, 2023
@spylogsster spylogsster requested a review from a team as a code owner February 27, 2023 14:01
@spylogsster spylogsster merged commit 0c3108f into master Feb 27, 2023
@spylogsster spylogsster deleted the brave-17377 branch February 27, 2023 17:32
@github-actions github-actions bot added this to the 1.50.x - Nightly milestone Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Win/Linux) New Private window should be New private window, in hamburger menu
2 participants