(Win/Linux) New Private window should be New private window, in hamburger menu

[stephendonner]

Implementation note (from @mkarolin; updated by @bsclifton)

• The _override.grd files can't be modified; these are auto-generated when we run npm run chromium_rebase_l10n
• The strings in the _override.grd files are based on automatic generic substitutions that are mapped in https://github.com/brave/brave-core/blob/master/script/lib/grd_string_replacements.py
• There is no mapping for Incognito -> private
• One option to solve this is to add a new string into app/brave_generated_resources.grd and then replace IDS_NEW_INCOGNITO_WINDOW with our string ID in code via a chromium_src override.

Original issue description

New Private window should be New private window, in hamburger menu

Windows and Linux desktop only;macOS is taken care of in #17308

Steps to Reproduce

• open the hamburger menu on the browser toolbar
• look at the capitalization of the menu items

Actual result:

Reads New Private window

Expected result:

New private window

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.30.3 Chromium: 92.0.4515.131 (Official Build) nightly (64-bit)
Revision	6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS	Windows 10 OS Version 2009 (Build 22000.120)

/cc @nullhook

[rebron]

@stephendonner Windows and Linux?

[stephendonner]

@stephendonner Windows and Linux?

Yup.

[SebastianLF]

Let's give it a try.

[stephendonner]

Let's give it a try.

Hi @SebastianLF by this, do you mean to say you'd like to try fixing this issue? If so, please confirm, and I'll assign to you; thanks!

[SebastianLF]

Let's give it a try.

Hi @SebastianLF by this, do you mean to say you'd like to try fixing this issue? If so, please confirm, and I'll assign to you; thanks!

Exactly. I will work on it tomorrow.

[SebastianLF]

Package 'libgnome-keyring-dev' is no more maintained on my actual version of ubuntu 20.04. I'll install version 18.04 in a new partition on my disk and make it work.

[stephendonner]

How's this going @SebastianLF? If for some reason you're (later) unable to make progress, please unassign it back, so others can also take a look; thanks!

[SebastianLF]

@stephendonner I installed ubuntu 18.04 and set up everything today. I certainly send a PR tomorrow.

[SebastianLF]

when "npm run init", it starts to download 16gb of data, why is that big ?

[bsclifton]

@SebastianLF running npm run init will download all of the source from Chromium (including history, which is the biggest). If you're able to compile locally, that's great. But you can still PR the text change without trying locally and we can try on our side with our CI (or building locally)

[SebastianLF]

@SebastianLF running npm run init will download all of the source from Chromium (including history, which is the biggest). If you're able to compile locally, that's great. But you can still PR the text change without trying locally and we can try on our side with our CI (or building locally)

Thanks for your answer, I'll do this way. Is it in 'generated_resources_override.grd' or 'generated_resources.grd' that the string should be modified?
Sorry guys for the delay.

[bsclifton]

@SebastianLF we have some info on our wiki here:
https://github.com/brave/brave-browser/wiki/Strings-and-Localization#chromium-strings

But I'm not seeing that addressed unfortunately. @mkarolin @petemill @mariospr do we have any docs for when to use app/generated_resources.grd versus app/generated_resources_override.grd?

[deepxcode]

I can work on this issue and make the PR asap.

[AnudeepGunukula]

Hi @bsclifton @stephendonner . i had made a pr that will close this issue
kindly review it and let me know the changes if needed.

[stephendonner]

Folks, thanks for your willingness to help; @SebastianLF still has this assigned to him, so I'd like to give him first attempt at solving it; thanks!

[SebastianLF]

PR: brave/brave-core#9821
Let me know if it works. If any error, I will modify accordingly.

[stephendonner]

PR: brave/brave-core#9821
Let me know if it works. If any error, I will modify accordingly.

Sorry for the delay; I've put a couple more reviewers on your PR, who will hopefully be able to take a look soon! 🙏

[bsclifton]

Thanks for the attempt @SebastianLF - I removed the good first issue tag as there is some complexity here due to the replacement done for Chromium strings by Brave. More information available in brave/brave-core#9821 (comment)

Updated the top issue with a note

[stephendonner]

Verified PASSED using

Brave	1.50.87 Chromium: 111.0.5563.64 (Official Build) dev (64-bit)
Revision	c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS	Linux

Confirmed string now reads New private window with Tor

[stephendonner]

Verified PASSED using

Brave	1.50.87 Chromium: 111.0.5563.64 (Official Build) dev (64-bit)
Revision	c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS	Windows 10 Version 22H2 (Build 19045.2673)

Confirmed string now reads New private window with Tor