-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brave notification permission issue fix #16740
Brave notification permission issue fix #16740
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
2309f11
to
5738fb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
5738fb8
to
47cfda3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
47cfda3
to
37e3159
Compare
Verification PASSED on
|
Example |
Example |
---|---|
Test Case #2
- brave/brave-browser#27851
As per @deeppandya, we don't block users from opting into Brave Rewards
when they have notifications disabled. We display the warning but a user can dismiss the modal by pressing X
and continue with onboarding. So the following verifies that the user received a warning when disabling either All Brave - notifications
or All "Brave Ads" notification
channels from Notifications
settings.
Test Case #1
- not enabling notifications via initial onboarding
- installed
1.49.82 Chromium: 110.0.5481.52
- tap on
Continue
under theBrave notifications make it easier
onboarding - tap on
Dont allow
under the `All Brave - Nightly to send you notifications?" modal - tap on the rewards panel and select a country via the
Select your country
panel - tapping on
Continue
should display theEnable notifications from Brave to earn Brave Rewards
modal- ensured that tapping
X
dismisses the modal and you can still run/setup rewards via the panel - ensured that tapping on
Open Settings
opensNotifications
underSettings
- ensured that tapping
screen-20230202-013647.mp4
Test Case #2
- disabling All Brave - notifications
via Settings
-> Notifications
- installed
1.49.82 Chromium: 110.0.5481.52
- tap on
Continue
under theBrave notifications make it easier
onboarding - tap on
Allow
under the `All Brave - Nightly to send you notifications?" modal - disable
All Brave - notifications
viaHamburger Menu
->Settings
->Notifications
- tap on the rewards panel via NTP and select a country via the
Select your country
panel - tapping on
Continue
should display theEnable notifications from Brave to earn Brave Rewards
modal- ensured that tapping
X
dismisses the modal and you can still run/setup rewards via the panel - ensured that tapping on
Open Settings
opensNotifications
underSettings
- ensured that tapping
screen-20230202-014548.mp4
Test Case #3
- disabling All "Brave Ads" notification
via Settings
-> Notifications
- installed
1.49.82 Chromium: 110.0.5481.52
- tap on
Continue
under theBrave notifications make it easier
onboarding - tap on
Allow
under the `All Brave - Nightly to send you notifications?" modal - disable
All "Brave Ads" notification
viaHamburger Menu
->Settings
->Notifications
- tap on the rewards panel via NTP and select a country via the
Select your country
panel - tapping on
Continue
should display theEnable notifications from Brave to earn Brave Rewards
modal- ensured that tapping
X
dismisses the modal and you can still run/setup rewards via the panel - ensured that tapping on
Open Settings
opensNotifications
underSettings
- ensured that tapping
screen-20230202-014823.mp4
Test Case #3
- brave/brave-browser#27852
Went through the STR/Cases outlined via brave/brave-browser#27852 (comment) and ensured that the Privacy Report
warning re: notifications being disabled when toggling both All Brave - notifications
and All "General" notifications
as per the following:
Resolves brave/brave-browser#27851
Resolves brave/brave-browser#27852
Resolves brave/brave-browser#27853
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
In this PR there are 3 changes
One more changes in this PR.
if notification permission is not there still allow to create reward wallet.
STR
Below two video for Get weekly privacy UI
https://user-images.githubusercontent.com/32419898/213454850-070afeb3-b3aa-4fd9-8ae8-ddb229aca3fc.mp4
https://user-images.githubusercontent.com/32419898/213454871-45f0989a-0bf4-4e62-9b3b-bdfd7e15716d.mp4
Rewards Panel
screen-20230120-220639.mp4
Dot at the end