Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get weekly privacy updates on tracker not being displayed when All "General" notifications disabled #27852

Closed
kjozwiak opened this issue Jan 17, 2023 · 3 comments · Fixed by brave/brave-core#16740

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Jan 17, 2023

Description

Similar to #27851, we're not displaying the Get weekly privacy updates on tracker & ad blocking. warning message under the Privacy Report when All "General" notifications has been disabled. It's only displayed when a user disables All Brave notifications.

Steps to reproduce

  1. download/install 1.47.175 Chromium: 109.0.5414.87
  2. run through all the onboarding and enable Privacy Report
  3. go into Settings -> Notification and disable All "General" notifications
  4. once disabled, go back into the NTP and tap on the stats to pull up the Privacy Report feature
  5. notice that there's no warnings regarding notifications being disabled
  6. go back into Settings -> Notifications and disable All Brave notifications
  7. you'll notice that the Privacy Report is now disabling the warning regarding the notifications being disabled

Actual result

Quick example can be found via --> https://youtu.be/UxJEeaq7wxU

Expected result

image

Issue reproduces how often

100% reproducible when using the STR/Cases outlined above.

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Pixel 6 (Phone)
  • Android version: Android 13

Brave version

Brave | 1.47.175 Chromium: 109.0.5414.87 (Official Build) (32-bit)
--- |  ---
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Android 13; Build/T2B2.221216.006

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

@deeppandya @timchilds @sujitacharya2005 @Uni-verse

@kjozwiak
Copy link
Member Author

kjozwiak commented Feb 2, 2023

@brave/qa-team more detailed STR/Cases can also be found via brave/brave-core#16740 (comment) 👍

@kjozwiak
Copy link
Member Author

kjozwiak commented Feb 2, 2023

The above requires 1.48.154 or higher for 1.48.x verification 👍

@kjozwiak
Copy link
Member Author

kjozwiak commented Feb 3, 2023

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.48.154 Chromium: 110.0.5481.52 (Official Build) (32-bit)
--- | ---
Revision | 979113183ded4544a2c443aceb1629c430907e52-refs/branch-heads/5481@{#636}
OS | Android 13; Build/TQ1A.230105.002

Went through the STR/Cases outlined via #27852 (comment) and ensured that the Privacy Report warning re: notifications being disabled when toggling both All Brave - notifications and All "General" notifications as per the following:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants