Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brave News]: Don't show subscribe button until opted in to Brave News #16161

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

fallaciousreasoning
Copy link
Contributor

Resolves brave/brave-browser#27057

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See issue

@stephendonner
Copy link
Contributor

Verified PASSED using

Brave 1.48.32 Chromium: 108.0.5359.94 (Official Build) nightly (x86_64)
Revision 713576b895246504ccc6b92c2fb8ce2d60194074-refs/branch-heads/5359_71@{#3}
OS macOS Version 11.7.1 (Build 20G918)

Steps:

  1. installed 1.48.32
  2. launched Brave
  3. opened brave://flags
  4. ensured there's no flag for the Brave News button
  5. loaded theatlantic.com
  6. ensured there's no Manage Subscriptions button visible in the URL bar
  7. opened a new-tab page
  8. ensured the Brave News opt-in page is still there
  9. clicked on Customize
  10. clicked on Brave News
  11. ensured the Brave News opt-in page is still there
  12. clicked on Show Brave News
  13. returned to theatlantic.com tab
  14. confirmed the Manage Subscriptions RSS-feed icon is in the URL bar

Confirmed the Manage Subscriptions RSS-feed icon isn't visible until opted-in to Brave News

example example example example example example example
Screen Shot 2022-12-07 at 10 21 54 AM Screen Shot 2022-12-07 at 10 25 25 AM Screen Shot 2022-12-07 at 10 25 32 AM Screen Shot 2022-12-07 at 10 25 59 AM Screen Shot 2022-12-07 at 10 26 05 AM Screen Shot 2022-12-07 at 10 26 17 AM Screen Shot 2022-12-07 at 10 26 22 AM

kjozwiak added a commit that referenced this pull request Dec 8, 2022
[Brave News Uplift]: Don't show subscribe button until opted in to Brave News #16161
kjozwiak added a commit that referenced this pull request Dec 8, 2022
[Brave News Uplift]: Don't show subscribe button until opted in to Brave News #16161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Brave News]: Subscribe button shouldn't show unless the user has opted in to Brave News.
3 participants