Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brave News]: Subscribe button shouldn't show unless the user has opted in to Brave News. #27057

Closed
fallaciousreasoning opened this issue Nov 30, 2022 · 5 comments · Fixed by brave/brave-core#16161

Comments

@fallaciousreasoning
Copy link

  1. Don't opt in to Brave News
  2. Visit a site with an RSS feed

Actual
The subscribe button shows up

Expected
The subscribe button does not show up because the user hasn't opted in to Brave News

@btlechowski
Copy link

btlechowski commented Dec 6, 2022

@rebron @LaurenWags @kjozwiak This fix needs an uplift to 1.47.x as it fixes many issues.

Issue 1: Unable to subscribe to feed through Brave News subscribe button on clean install
Unable to subscribe to first feed
image

Issue 2: Blank page after subscribing to a feed and enabling Brave news
image

@rebron
Copy link
Collaborator

rebron commented Dec 6, 2022

@fallaciousreasoning @petemill Can we get uplifts for this for 1.47.x and 1.46.x?

@fallaciousreasoning
Copy link
Author

1.46.x: brave/brave-core#16265
1.47.x: brave/brave-core#16266

@kjozwiak
Copy link
Member

kjozwiak commented Dec 8, 2022

The above requires 1.47.120 or higher for 1.47.x verification 👍

@stephendonner
Copy link

Verified PASSSED using

Brave 1.47.120 Chromium: 108.0.5359.99 (Official Build) dev (x86_64)
Revision 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS macOS Version 13.1 (Build 22C65)

Steps:

  1. installed 1.47.120
  2. launched Brave
  3. opened brave://flags
  4. ensured there's no flag for the Brave News button
  5. loaded theatlantic.com
  6. ensured there's no Manage Subscriptions button visible in the URL bar
  7. opened a new-tab page
  8. ensured the Brave News opt-in page is still there
  9. clicked on Customize
  10. clicked on Brave News
  11. ensured the Brave News opt-in page is still there
  12. clicked on Show Brave News
  13. returned to theatlantic.com tab
  14. confirmed the Manage Subscriptions RSS-feed icon is in the URL bar

Confirmed the Manage Subscriptions RSS-feed icon isn't visible until opted-in to Brave News

example example example example example example example
Screenshot 2022-12-08 at 5 32 29 PM . Screenshot 2022-12-08 at 6 57 31 PM Screenshot 2022-12-08 at 6 57 40 PM Screenshot 2022-12-08 at 6 57 49 PM Screenshot 2022-12-08 at 6 58 32 PM Screenshot 2022-12-08 at 6 58 40 PM Screenshot 2022-12-08 at 6 58 43 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment