-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Brave News]: Subscribe button shouldn't show unless the user has opted in to Brave News. #27057
Comments
@rebron @LaurenWags @kjozwiak This fix needs an uplift to 1.47.x as it fixes many issues. Issue 1: Unable to subscribe to feed through Brave News subscribe button on clean install Issue 2: Blank page after subscribing to a feed and enabling Brave news |
@fallaciousreasoning @petemill Can we get uplifts for this for 1.47.x and 1.46.x? |
1.46.x: brave/brave-core#16265 |
The above requires |
Verified
|
Brave | 1.47.120 Chromium: 108.0.5359.99 (Official Build) dev (x86_64) |
---|---|
Revision | 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9} |
OS | macOS Version 13.1 (Build 22C65) |
Steps:
- installed
1.47.120
- launched Brave
- opened
brave://flags
- ensured there's no flag for the Brave News button
- loaded
theatlantic.com
- ensured there's no
Manage Subscriptions
button visible in the URL bar - opened a new-tab page
- ensured the Brave News opt-in page is still there
- clicked on
Customize
- clicked on
Brave News
- ensured the Brave News opt-in page is still there
- clicked on
Show Brave News
- returned to
theatlantic.com
tab - confirmed the
Manage Subscriptions
RSS-feed icon is in the URL bar
Confirmed the Manage Subscriptions
RSS-feed icon isn't visible until opted-in to Brave News
example | example | example | example | example | example | example |
---|---|---|---|---|---|---|
. |
Actual
The subscribe button shows up
Expected
The subscribe button does not show up because the user hasn't opted in to Brave News
The text was updated successfully, but these errors were encountered: