-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes panel db query #1589
Fixes panel db query #1589
Conversation
480397b
to
d698c42
Compare
d698c42
to
89518b0
Compare
89518b0
to
af4e5d4
Compare
|
||
info_sql.BindString(0, filter.id); | ||
info_sql.BindInt64(1, filter.reconcile_stamp); | ||
info_sql.BindString(2, filter.id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like has already been bound, is this unneeded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The args need to be bound, not the id. arg[2] hasn't been bound yet here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup we need it as we have three ?
in the query and we use id in two places
Resolves brave/brave-browser#3244
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) ongit rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist: