Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

youtube publisher is shown for media publisher #3244

Closed
NejcZdovc opened this issue Feb 6, 2019 · 2 comments · Fixed by brave/brave-core#1589
Closed

youtube publisher is shown for media publisher #3244

NejcZdovc opened this issue Feb 6, 2019 · 2 comments · Fixed by brave/brave-core#1589

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Feb 6, 2019

Description

youtube publisher is shown instead of media publisher if you already visited that publisher in previous contribution cycle

Steps to Reproduce

  1. clean profile
  2. visit some youtube publisher video
  3. make sure that publisher is recorded in ac table
  4. close browser
  5. open publisher db and modify reconcile stamp to something in the past
  6. open browser again and visit the same publisher (from step 2)

Actual result:

youtube publisher is shown

Expected result:

media publisher for that video should be shown

Reproduces how often:

100%

Brave version (brave://version info)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@NejcZdovc
Copy link
Contributor Author

@kjozwiak @rebron @bbondy would be really good to pull this one into 0.60

@btlechowski
Copy link

btlechowski commented Feb 25, 2019

Verification passed on

Brave 0.61.37 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 7 Service Pack 1 Build 7601.24312

Used test plan from brave/brave-core#1589

Verification PASSED on macOS 10.14.3 x64 using the following build:

Brave 0.61.45 Chromium: 73.0.3683.39 (Official Build) beta(64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Mac OS X

Verification passed on

Brave 0.61.41 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Linux mint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants