Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): ERC721 Token Registry Icons #15847

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

Douglashdaniel
Copy link
Contributor

@Douglashdaniel Douglashdaniel commented Nov 8, 2022

Description

Fixes broken icons for ERC721 tokens in the Token Registry

Resolves brave/brave-browser#26594

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open the Edit Visible Assets modal
  2. Search for Crypto Kitties
  3. The Icon fro Crypto Kitties should not be broken.

Before:

Screen.Recording.2022-11-07.at.1.15.18.PM.mov

After:

Screen.Recording.2022-11-08.at.11.14.29.AM.mov

@Douglashdaniel Douglashdaniel self-assigned this Nov 8, 2022
@Douglashdaniel Douglashdaniel requested a review from a team as a code owner November 8, 2022 17:29
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Nov 8, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel merged commit 09ca8f2 into master Nov 8, 2022
@Douglashdaniel Douglashdaniel deleted the fix-erc721-token-registry-icons branch November 8, 2022 22:37
@github-actions github-actions bot added this to the 1.47.x - Nightly milestone Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images are Broken For ERC721 Tokens in Token Registry
3 participants