Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images are Broken For ERC721 Tokens in Token Registry #26594

Closed
Douglashdaniel opened this issue Nov 7, 2022 · 1 comment · Fixed by brave/brave-core#15847
Closed

Images are Broken For ERC721 Tokens in Token Registry #26594

Douglashdaniel opened this issue Nov 7, 2022 · 1 comment · Fixed by brave/brave-core#15847
Assignees
Labels

Comments

@Douglashdaniel
Copy link

Description

ERC721 Token Images are broken in the Token Registry list

Steps to Reproduce

  1. Open the Edit Visible Assets modal
  2. Search for Crypto Kitties
  3. The asset item will have a broken image.

Actual result:

Screen Shot 2022-11-07 at 12 59 20 PM

Expected result:

The image should not be broken, should either show the Image that is returned or a placeholder icon.

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@Douglashdaniel Douglashdaniel added QA/Yes release-notes/include regression feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Nov 7, 2022
@Douglashdaniel Douglashdaniel changed the title ERC721 Token Images are Broken For Token Registry List Images are Broken For ERC721 Tokens in Token Registry Nov 7, 2022
@Douglashdaniel Douglashdaniel self-assigned this Nov 8, 2022
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Nov 8, 2022
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Nov 8, 2022
Repository owner moved this from In Review to Done in Web3 Nov 8, 2022
@brave-builds brave-builds added this to the 1.47.x - Nightly milestone Nov 8, 2022
@srirambv
Copy link
Contributor

srirambv commented Dec 14, 2022

Verification passed on

Brave 1.47.126 Chromium: 108.0.5359.99 (Official Build) beta (64-bit)
Revision 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS Linux
  • Verified steps from brave/brave-core#15847
  • Verified ERC721 tokens from token registry shows image when search for
Crypto Kitties Punks Comic
image image

Verification passed on

Brave 1.47.126 Chromium: 108.0.5359.99 (Official Build) beta (64-bit)
Revision 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#15847
  • Verified ERC721 tokens from token registry shows image when search for
Crypto Kitties Punks Comic
image image

Verification passed on

Brave 1.47.126 Chromium: 108.0.5359.99 (Official Build) beta (arm64)
Revision 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#15847
  • Verified ERC721 tokens from token registry shows image when search for
Crypto Kitties Punks Comic
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants