Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SKUs SDK Time Limited V2 Implementation (uplift to 1.45.x) #15663

Closed
wants to merge 1 commit into from
Closed

SKUs SDK Time Limited V2 Implementation (uplift to 1.45.x) #15663

wants to merge 1 commit into from

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Oct 25, 2022 •
edited by bsclifton
Loading

Uplift of #15465
Resolves brave/brave-browser#21646

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner October 25, 2022 21:19
@brave-builds brave-builds self-assigned this Oct 25, 2022
@brave-builds brave-builds added this to the 1.45.x - Release #2 milestone Oct 25, 2022
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Oct 25, 2022
@bsclifton bsclifton removed this from the 1.45.x - Release #4 milestone Oct 28, 2022
@bsclifton
Copy link
Member

Closing as we pushing VPN feature in the 1.45.x maintenance release is way too tight at this point

@bsclifton bsclifton closed this Oct 28, 2022
@bsclifton bsclifton deleted the pr15465_bh-skus-sdk-tlv2_1.45.x branch October 28, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brave-builds brave-builds

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @bsclifton @kjozwiak @brave-browser-releases