Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logic in fetch-order-credentials for v2 time-limited credentials #21646

Closed
Tracked by #26034
mattmcalister opened this issue Mar 14, 2022 · 2 comments · Fixed by brave/brave-core#15465
Closed
Tracked by #26034

Add logic in fetch-order-credentials for v2 time-limited credentials #21646

mattmcalister opened this issue Mar 14, 2022 · 2 comments · Fixed by brave/brave-core#15465
Assignees
@husobee @evq
Labels
feature/vpn OS/Desktop premium All issues related to Brave Premium priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Milestone
1.46.x - Release

Comments

@mattmcalister
Copy link

mattmcalister commented Mar 14, 2022 •
edited by bsclifton
Loading

Test plan

Would be covered in the general VPN testing. See #25680 for more information.

Description

Credentialing used by the SKU SDK system ("time limited credentials").

See security review for more detailed information:
https://github.com/brave/security/issues/738
@mattmcalister mattmcalister added priority/P2 A bad problem. We might uplift this to the next planned release. OS/Desktop feature/vpn premium All issues related to Brave Premium labels Mar 14, 2022
@mattmcalister mattmcalister assigned bsclifton and unassigned bsclifton Mar 14, 2022
@husobee husobee mentioned this issue Oct 14, 2022
Merged
25 tasks
@mattmcalister mattmcalister mentioned this issue Oct 14, 2022
Closed
2 tasks
@bsclifton bsclifton added this to the 1.47.x - Nightly milestone Oct 25, 2022
@bsclifton
Copy link
Member

Marking as QA/No only because this will be tested within the scope of the VPN project

@bsclifton
Copy link
Member

Fixed with brave/brave-core#15465

This was referenced Oct 25, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@husobee husobee

@evq evq

Labels
feature/vpn OS/Desktop premium All issues related to Brave Premium priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Projects
None yet
Milestone
1.46.x - Release
Development

Successfully merging a pull request may close this issue.

SKUs SDK Time Limited V2 Implementation brave/brave-core
5 participants
@mattmcalister @bsclifton @husobee @evq @brave-builds